Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2352023002: Minor cleanups in RTPSender::UpdateRtpStats (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor cleanups in RTPSender::UpdateRtpStats ssrc taken from packet instead of module removing extra lock removed unneccesary call to clock_ reduced number of lines. BUG=webrtc:5565 R=brandtr@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d69e526440eed24b8b2977130500f7c4e6592be7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +8 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
danilchap
4 years, 3 months ago (2016-09-20 08:53:53 UTC) #3
brandtr
Add a newline between first and second row of commit message. lgtm
4 years, 3 months ago (2016-09-20 11:22:00 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d69e526440eed24b8b2977130500f7c4e6592be7 Cr-Commit-Position: refs/heads/master@{#14307}
4 years, 3 months ago (2016-09-20 13:48:23 UTC) #7
danilchap
4 years, 3 months ago (2016-09-20 13:48:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d69e526440eed24b8b2977130500f7c4e6592be7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698