Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: webrtc/media/base/fakevideocapturer.h

Issue 2351633002: Let ViEEncoder handle resolution changes. (Closed)
Patch Set: Fix perf test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/fakevideocapturer.h
diff --git a/webrtc/media/base/fakevideocapturer.h b/webrtc/media/base/fakevideocapturer.h
index 8ba56f1e6f1971ee1e27aefcd823316598ff818d..6862343b9c74190239b3122cc74e4d830f9bffa9 100644
--- a/webrtc/media/base/fakevideocapturer.h
+++ b/webrtc/media/base/fakevideocapturer.h
@@ -29,7 +29,7 @@ namespace cricket {
// Fake video capturer that allows the test to manually pump in frames.
class FakeVideoCapturer : public cricket::VideoCapturer {
public:
- FakeVideoCapturer(bool is_screencast)
+ explicit FakeVideoCapturer(bool is_screencast)
: running_(false),
initial_timestamp_(rtc::TimeNanos()),
next_timestamp_(rtc::kNumNanosecsPerMillisec),
@@ -125,9 +125,7 @@ class FakeVideoCapturer : public cricket::VideoCapturer {
cricket::CaptureState Start(const cricket::VideoFormat& format) override {
cricket::VideoFormat supported;
sprang_webrtc 2016/09/22 13:06:16 Not needed anymore?
perkj_webrtc 2016/09/26 12:09:42 Done.
- if (GetBestCaptureFormat(format, &supported)) {
- SetCaptureFormat(&supported);
- }
+ SetCaptureFormat(&format);
running_ = true;
SetCaptureState(cricket::CS_RUNNING);
return cricket::CS_RUNNING;

Powered by Google App Engine
This is Rietveld 408576698