AcmReceiver: Eliminate AcmReceiver::decoders_

webrtc/modules/audio_coding/codecs/audio_format.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 15 matching lines @@
                                Parameters&& param)
     : name(name),
       clockrate_hz(clockrate_hz),
       num_channels(num_channels),
       parameters(std::move(param)) {}
 
 SdpAudioFormat::~SdpAudioFormat() = default;
 SdpAudioFormat& SdpAudioFormat::operator=(const SdpAudioFormat&) = default;
 SdpAudioFormat& SdpAudioFormat::operator=(SdpAudioFormat&&) = default;
 
+bool operator==(const SdpAudioFormat& a, const SdpAudioFormat& b) {
+  return a.name == b.name && a.clockrate_hz == b.clockrate_hz &&
+         a.num_channels == b.num_channels && a.parameters == b.parameters;

[kwiberg-webrtc, 2016/09/20 15:21:00]

Should the .name comparison be case-insensitive?

[ossu, 2016/09/20 15:30:55]

I think it should. We're doing case-insensitive matching of these names
everywhere else in the code, so it makes sense that this would be done here as
well.

[kwiberg-webrtc, 2016/09/20 16:30:29]

Done.

+}
+
 void swap(SdpAudioFormat& a, SdpAudioFormat& b) {
   using std::swap;
   swap(a.name, b.name);
   swap(a.clockrate_hz, b.clockrate_hz);
   swap(a.num_channels, b.num_channels);
   swap(a.parameters, b.parameters);
 }
 
 std::ostream& operator<<(std::ostream& os, const SdpAudioFormat& saf) {
   os << "{name: " << saf.name;
   os << ", clockrate_hz: " << saf.clockrate_hz;
   os << ", num_channels: " << saf.num_channels;
   os << ", parameters: {";
   const char* sep = "";
   for (const auto& kv : saf.parameters) {
     os << sep << kv.first << ": " << kv.second;
     sep = ", ";
   }
   os << "}}";
   return os;
 }
 
 }  // namespace webrtc