Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2351163002: Roll chromium_revision cf9457edb7..cede888c27 (416297:419407) (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision cf9457edb7..cede888c27 (416297:419407) This is a reland of https://codereview.webrtc.org/2348133003/ which was reverted. This CL adds a copy of Chromium's build/filename_rules.gypi into webrtc/build and includes it in webrtc/build/common.gypi. This was needed since the file was dropped in crrev.com/8c0eb8ed76 The revision of filename_rules.gypi being added is: https://chromium.googlesource.com/chromium/src/+/5b20e75e681cb9aaa2d8d9696a9954417c9cc068/build/filename_rules.gypi Change log: https://chromium.googlesource.com/chromium/src/+log/cf9457edb7..cede888c27 Full diff: https://chromium.googlesource.com/chromium/src/+/cf9457edb7..cede888c27 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/adb8bf4e8f..6115afa0ea * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/bc61769e49..ed6c5d3910 * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/35740fc7b7..3c7a098821 * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/96e97b48e8..eb9b8b0366 * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/e66cd132f0..4282d29355 DEPS diff: https://chromium.googlesource.com/chromium/src/+/cf9457edb7..cede888c27/DEPS Clang version changed 280106:280836 Details: https://chromium.googlesource.com/chromium/src/+/cf9457edb7..cede888c27/tools/clang/scripts/update.py NOTRY=True TBR=marpan@webrtc.org, BUG=None Committed: https://crrev.com/519da00bb3911c8812af7bd76d84c9511778e8fb Cr-Commit-Position: refs/heads/master@{#14310}

Patch Set 1 #

Patch Set 2 : Update filename_includes.gypi license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M all.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/build/filename_rules.gypi View 1 1 chunk +105 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/cpu_features_webrtc.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
This should fix the downstream GYP problem we were seeing.
4 years, 3 months ago (2016-09-20 13:00:38 UTC) #3
ehmaldonado_webrtc
On 2016/09/20 13:00:38, kjellander_webrtc wrote: > This should fix the downstream GYP problem we were ...
4 years, 3 months ago (2016-09-20 13:03:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2351163002/20001
4 years, 3 months ago (2016-09-20 20:17:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 20:23:08 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:23:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/519da00bb3911c8812af7bd76d84c9511778e8fb
Cr-Commit-Position: refs/heads/master@{#14310}

Powered by Google App Engine
This is Rietveld 408576698