Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2350103002: Improves resolution when logging rate in the ADB class (Closed)

Created:
4 years, 3 months ago by henrika_webrtc
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improves resolution when logging rate in the ADB class. Trivial patch which fixes an issue where logged rate estimates could be invalid. E.g. on iOS, two successive timer interrupts can be ~10.5 seconds and not exactly 10.0 (which is usually the case on Android). In those cases we could log a rate estimate of e.g. ~51000Hz instead of ~48000Hz. This CL fixes that. BUG=NONE Committed: https://crrev.com/a6d26ec6a2a6eccb35b3456010956bf4f53a2659 Cr-Commit-Position: refs/heads/master@{#14305}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback from hlundin@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
henrika_webrtc
Henrik, PTAL
4 years, 3 months ago (2016-09-19 14:44:00 UTC) #3
hlundin-webrtc
LGTM with one nit. https://codereview.webrtc.org/2350103002/diff/1/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2350103002/diff/1/webrtc/modules/audio_device/audio_device_buffer.cc#newcode401 webrtc/modules/audio_device/audio_device_buffer.cc:401: if (++num_stat_reports_ > 1) { ...
4 years, 3 months ago (2016-09-20 07:30:25 UTC) #4
henrika_webrtc
https://codereview.webrtc.org/2350103002/diff/1/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2350103002/diff/1/webrtc/modules/audio_device/audio_device_buffer.cc#newcode401 webrtc/modules/audio_device/audio_device_buffer.cc:401: if (++num_stat_reports_ > 1) { Thanks!
4 years, 3 months ago (2016-09-20 09:05:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2350103002/20001
4 years, 3 months ago (2016-09-20 09:05:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 11:44:08 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 11:44:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6d26ec6a2a6eccb35b3456010956bf4f53a2659
Cr-Commit-Position: refs/heads/master@{#14305}

Powered by Google App Engine
This is Rietveld 408576698