Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2349973002: Revert of AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one (patchset #2 id:20001 of https://codereview.webrtc.org/2342313002/ ) Reason for revert: Seems to have broken Chromium tests. Original issue's description: > AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one > > It requires a new NetEq method, but it can no longer fail. And we no > longer need to use AcmReceiver::decoders_, which we're trying to > eliminate. > > BUG=webrtc:5801 > > Committed: https://crrev.com/f6232b43a176e1717354b671a0a52b887d70de59 > Cr-Commit-Position: refs/heads/master@{#14275} TBR=ossu@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5801 Committed: https://crrev.com/bfb78d12932a339d09fb3561ff11960d277fbaeb Cr-Commit-Position: refs/heads/master@{#14278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +19 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
Created Revert of AcmReceiver: Ask NetEq to delete all decoders at once instead of one ...
4 years, 3 months ago (2016-09-18 12:33:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2349973002/1
4 years, 3 months ago (2016-09-18 12:33:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 12:33:44 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bfb78d12932a339d09fb3561ff11960d277fbaeb Cr-Commit-Position: refs/heads/master@{#14278}
4 years, 3 months ago (2016-09-18 12:33:56 UTC) #6
hlundin-webrtc
4 years, 3 months ago (2016-09-19 12:07:53 UTC) #7
Message was sent while issue was closed.
RS LGTM

Powered by Google App Engine
This is Rietveld 408576698