Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h

Issue 2348803003: Remove differ from ScreenCapturer implementations (Closed)
Patch Set: Comment on the XDamage scenario in screen_capturer_x11.cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h
diff --git a/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h b/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h
index 969cb83bcfaa31e859e26cf60905d733e7e8c036..080a57cdaaa7c2266156e1bf35949f6c4e2591c8 100644
--- a/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h
+++ b/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h
@@ -29,12 +29,15 @@ namespace webrtc {
class DesktopFrame;
class DesktopRect;
-class Differ;
// Captures the screen using the Magnification API to support window exclusion.
// Each capturer must run on a dedicated thread because it uses thread local
// storage for redirecting the library callback. Also the thread must have a UI
// message loop to handle the window messages for the magnifier window.
+//
+// This class does not detect DesktopFrame::updated_region(), the field is
+// always set to the entire frame rectangle. ScreenCapturerDifferWrapper should
+// be used if that functionality is necessary.
class ScreenCapturerWinMagnifier : public ScreenCapturer {
public:
// |fallback_capturer| will be used to capture the screen if a non-primary
@@ -116,9 +119,6 @@ class ScreenCapturerWinMagnifier : public ScreenCapturer {
// Queue of the frames buffers.
ScreenCaptureFrameQueue<SharedDesktopFrame> queue_;
- // Class to calculate the difference between two screen bitmaps.
- std::unique_ptr<Differ> differ_;
-
ScopedThreadDesktop desktop_;
// Used for getting the screen dpi.

Powered by Google App Engine
This is Rietveld 408576698