Remove differ from ScreenCapturer implementations

Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802
Committed: https://crrev.com/c59bf0415a949008a7c14f28f2429a1b5021c95d
Cr-Commit-Position: refs/heads/master@{#14377}

[Hzj_jie, 2016-09-16 18:41:15]

Description was changed from

==========
Remove differ from various ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=314516
==========

to

==========
Remove differ from various ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

TODO(zijiehe): Remove Differ from ScreenCapturerWinMagnifier once change
2319383002 has been submitted.

BUG=314516
==========

[Hzj_jie, 2016-09-16 18:42:44]

Description was changed from

==========
Remove differ from various ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

TODO(zijiehe): Remove Differ from ScreenCapturerWinMagnifier once change
2319383002 has been submitted.

BUG=314516
==========

to

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

TODO(zijiehe): Remove Differ from ScreenCapturerWinMagnifier once change
2319383002 has been submitted.

BUG=314516
==========

[Hzj_jie, 2016-09-22 00:38:06]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-09-22 00:38:58]

Description was changed from

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

TODO(zijiehe): Remove Differ from ScreenCapturerWinMagnifier once change
2319383002 has been submitted.

BUG=314516
==========

to

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802
==========

[Hzj_jie, 2016-09-22 01:01:24]

Patchset #1 (id:20001) has been deleted

[Hzj_jie, 2016-09-22 01:37:35]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Sergey Ulanov, 2016-09-22 18:25:08]

Can you also remove Differ class in this CL since it should no longer be used
anywhere?

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc (right):

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc:93: //
ScreenCapturerDifferWrapper will help to detect updated region if needed.
I suggest adding a comment in screen_capturer_win_gdi.h saying that this class
doesn't detect updated_region() and that ScreenCapturerDifferWrapper should be
used if that functionality is necessary. Then this comment can be removed.

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
(right):

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc:122: //
ScreenCapturerDifferWrapper will help to detect updated region if needed.
Same here. Add a comment in screen_capturer_win_magnifier.h

[Hzj_jie, 2016-09-22 20:01:49]

Patchset #2 (id:60001) has been deleted

[Hzj_jie, 2016-09-22 21:01:34]

Sure, updated.

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc (right):

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc:93: //
ScreenCapturerDifferWrapper will help to detect updated region if needed.
On 2016/09/22 18:25:08, Sergey Ulanov wrote:
> I suggest adding a comment in screen_capturer_win_gdi.h saying that this class
> doesn't detect updated_region() and that ScreenCapturerDifferWrapper should be
> used if that functionality is necessary. Then this comment can be removed.

Done.

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
(right):

https://codereview.chromium.org/2348803003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc:122: //
ScreenCapturerDifferWrapper will help to detect updated region if needed.
On 2016/09/22 18:25:08, Sergey Ulanov wrote:
> Same here. Add a comment in screen_capturer_win_magnifier.h

Done.

[Sergey Ulanov, 2016-09-24 00:09:15]

lgtm

https://codereview.chromium.org/2348803003/diff/80001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/screen_capturer_x11.cc (right):

https://codereview.chromium.org/2348803003/diff/80001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/screen_capturer_x11.cc:42: // always set to the
entire frame rectangle. ScreenCapturerDifferWrapper should
This is not correct. updated_region() may or may not be set, depending on
XDamage support in the X server

[Hzj_jie, 2016-09-24 00:12:38]

https://codereview.chromium.org/2348803003/diff/80001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/screen_capturer_x11.cc (right):

https://codereview.chromium.org/2348803003/diff/80001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/screen_capturer_x11.cc:42: // always set to the
entire frame rectangle. ScreenCapturerDifferWrapper should
On 2016/09/24 00:09:15, Sergey Ulanov wrote:
> This is not correct. updated_region() may or may not be set, depending on
> XDamage support in the X server

Updated.

[Hzj_jie, 2016-09-24 00:34:46]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-09-24 00:34:47]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2348803003/#ps100001
(title: "Comment on the XDamage scenario in screen_capturer_x11.cc")

[commit-bot: I haz the power, 2016-09-24 00:34:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-24 00:54:35]

Description was changed from

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802
==========

to

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802
==========

[commit-bot: I haz the power, 2016-09-24 00:54:36]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-09-24 00:54:43]

Description was changed from

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802
==========

to

==========
Remove differ from ScreenCapturer implementations

We can use ScreenCapturerDifferWrapper if needed, otherwise ScreenCapturer does
not need to calculate updated region itself, setting to entire screen is enough.

BUG=633802

Committed: https://crrev.com/c59bf0415a949008a7c14f28f2429a1b5021c95d
Cr-Commit-Position: refs/heads/master@{#14377}
==========

[commit-bot: I haz the power, 2016-09-24 00:54:44]

Patchset 3 (id:??) landed as
https://crrev.com/c59bf0415a949008a7c14f28f2429a1b5021c95d
Cr-Commit-Position: refs/heads/master@{#14377}