Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h
index ef99e172977b2d8f54023ea030b4602f074b7aa1..bdc3cbcd1f0e9333aee56e0a36ac2b0b9fed402c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h
@@ -30,17 +30,17 @@ class ReportBlock {
// Consumes ReportBlock::kLength bytes.
void Create(uint8_t* buffer) const;
- void To(uint32_t ssrc) { source_ssrc_ = ssrc; }
- void WithFractionLost(uint8_t fraction_lost) {
+ void SetMediaSsrc(uint32_t ssrc) { source_ssrc_ = ssrc; }
+ void SetFractionLost(uint8_t fraction_lost) {
fraction_lost_ = fraction_lost;
}
- bool WithCumulativeLost(uint32_t cumulative_lost);
- void WithExtHighestSeqNum(uint32_t ext_highest_seq_num) {
+ bool SetCumulativeLost(uint32_t cumulative_lost);
+ void SetExtHighestSeqNum(uint32_t ext_highest_seq_num) {
extended_high_seq_num_ = ext_highest_seq_num;
}
- void WithJitter(uint32_t jitter) { jitter_ = jitter; }
- void WithLastSr(uint32_t last_sr) { last_sr_ = last_sr; }
- void WithDelayLastSr(uint32_t delay_last_sr) {
+ void SetJitter(uint32_t jitter) { jitter_ = jitter; }
+ void SetLastSr(uint32_t last_sr) { last_sr_ = last_sr; }
+ void SetDelayLastSr(uint32_t delay_last_sr) {
delay_since_last_sr_ = delay_last_sr;
}

Powered by Google App Engine
This is Rietveld 408576698