Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
index 9f10921c9942066eda5c19d2e5698e50859746b1..5cc00a296433902d0c351dbea50cbb9fb1f7eea9 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
@@ -25,6 +25,7 @@ class CommonHeader;
class Remb : public Psfb {
public:
static constexpr uint8_t kFeedbackMessageType = 15;
+ static constexpr size_t kMaxNumberOfSsrcs = 0xff;
Remb() : bitrate_bps_(0) {}
~Remb() override {}
@@ -32,9 +33,8 @@ class Remb : public Psfb {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- bool AppliesTo(uint32_t ssrc);
- bool AppliesToMany(const std::vector<uint32_t>& ssrcs);
- void WithBitrateBps(uint64_t bitrate_bps) { bitrate_bps_ = bitrate_bps; }
+ bool SetSsrcs(std::vector<uint32_t> ssrcs);
+ void SetBitrateBps(uint64_t bitrate_bps) { bitrate_bps_ = bitrate_bps; }
uint64_t bitrate_bps() const { return bitrate_bps_; }
const std::vector<uint32_t>& ssrcs() const { return ssrcs_; }
@@ -50,11 +50,10 @@ class Remb : public Psfb {
}
private:
- static constexpr size_t kMaxNumberOfSsrcs = 0xff;
static constexpr uint32_t kUniqueIdentifier = 0x52454D42; // 'R' 'E' 'M' 'B'.
// Media ssrc is unused, shadow base class setter and getter.
- void To(uint32_t);
+ void SetMediaSsrc(uint32_t);
uint32_t media_ssrc() const;
uint64_t bitrate_bps_;

Powered by Google App Engine
This is Rietveld 408576698