Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
index ddf2cfaf2a4319cca617bbed86e0b41d4bf4de75..59f3b617294d63322b2e9fe3baf0fa01b2c115d6 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
@@ -36,8 +36,8 @@ class Fir : public Psfb {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void WithRequestTo(uint32_t ssrc, uint8_t seq_num) {
- items_.push_back(Request(ssrc, seq_num));
+ void AddRequestTo(uint32_t ssrc, uint8_t seq_num) {
+ items_.emplace_back(ssrc, seq_num);
}
const std::vector<Request>& requests() const { return items_; }
@@ -53,7 +53,7 @@ class Fir : public Psfb {
return kHeaderLength + kCommonFeedbackLength + kFciLength * items_.size();
}
// SSRC of media source is not used in FIR packet. Shadow base functions.
- void To(uint32_t ssrc);
+ void SetMediaSsrc(uint32_t ssrc);
uint32_t media_ssrc() const;
std::vector<Request> items_;

Powered by Google App Engine
This is Rietveld 408576698