Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc
index 9e704b12da50eae0d9a8592c2262efe531f1bacc..0199b5276a31159d512e512ea97e69f213fd37b2 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc
@@ -91,7 +91,7 @@ bool ExtendedReports::Parse(const CommonHeader& packet) {
return true;
}
-bool ExtendedReports::WithRrtr(const Rrtr& rrtr) {
+bool ExtendedReports::AddRrtr(const Rrtr& rrtr) {
if (rrtr_blocks_.size() >= kMaxNumberOfRrtrBlocks) {
LOG(LS_WARNING) << "Max RRTR blocks reached.";
return false;
@@ -100,7 +100,7 @@ bool ExtendedReports::WithRrtr(const Rrtr& rrtr) {
return true;
}
-bool ExtendedReports::WithDlrr(const Dlrr& dlrr) {
+bool ExtendedReports::AddDlrr(const Dlrr& dlrr) {
if (dlrr_blocks_.size() >= kMaxNumberOfDlrrBlocks) {
LOG(LS_WARNING) << "Max DLRR blocks reached.";
return false;
@@ -109,7 +109,7 @@ bool ExtendedReports::WithDlrr(const Dlrr& dlrr) {
return true;
}
-bool ExtendedReports::WithVoipMetric(const VoipMetric& voip_metric) {
+bool ExtendedReports::AddVoipMetric(const VoipMetric& voip_metric) {
if (voip_metric_blocks_.size() >= kMaxNumberOfVoipMetricBlocks) {
LOG(LS_WARNING) << "Max Voip Metric blocks reached.";
return false;

Powered by Google App Engine
This is Rietveld 408576698