Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc
index abc8f04f00959f5999af9033720d473291ffeb1a..6015ab874484cde3e492caed6fc45523e1091e5d 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc
@@ -53,9 +53,9 @@ constexpr uint8_t kPacketWithUnalignedPayload[] = {
TEST(RtcpPacketAppTest, CreateWithoutData) {
App app;
- app.From(kSenderSsrc);
- app.WithSubType(kSubtype);
- app.WithName(kName);
+ app.SetSsrc(kSenderSsrc);
+ app.SetSubType(kSubtype);
+ app.SetName(kName);
rtc::Buffer raw = app.Build();
@@ -75,10 +75,10 @@ TEST(RtcpPacketAppTest, ParseWithoutData) {
TEST(RtcpPacketAppTest, CreateWithData) {
App app;
- app.From(kSenderSsrc);
- app.WithSubType(kSubtype);
- app.WithName(kName);
- app.WithData(kData, sizeof(kData));
+ app.SetSsrc(kSenderSsrc);
+ app.SetSubType(kSubtype);
+ app.SetName(kName);
+ app.SetData(kData, sizeof(kData));
rtc::Buffer raw = app.Build();
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698