Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
11 11
12 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_ 12 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_
13 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_ 13 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_
14 14
15 #include "webrtc/base/basictypes.h" 15 #include "webrtc/base/basictypes.h"
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h" 16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 namespace rtcp { 19 namespace rtcp {
20 20
21 // PSFB: Payload-specific feedback message. 21 // PSFB: Payload-specific feedback message.
22 // RFC 4585, Section 6.3. 22 // RFC 4585, Section 6.3.
23 class Psfb : public RtcpPacket { 23 class Psfb : public RtcpPacket {
24 public: 24 public:
25 static constexpr uint8_t kPacketType = 206; 25 static constexpr uint8_t kPacketType = 206;
26 26
27 Psfb() : sender_ssrc_(0), media_ssrc_(0) {} 27 Psfb() : sender_ssrc_(0), media_ssrc_(0) {}
28 ~Psfb() override {} 28 ~Psfb() override {}
29 29
30 void From(uint32_t ssrc) { sender_ssrc_ = ssrc; } 30 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
31 void To(uint32_t ssrc) { media_ssrc_ = ssrc; } 31 void SetMediaSsrc(uint32_t ssrc) { media_ssrc_ = ssrc; }
32 32
33 uint32_t sender_ssrc() const { return sender_ssrc_; } 33 uint32_t sender_ssrc() const { return sender_ssrc_; }
34 uint32_t media_ssrc() const { return media_ssrc_; } 34 uint32_t media_ssrc() const { return media_ssrc_; }
35 35
36 protected: 36 protected:
37 static constexpr size_t kCommonFeedbackLength = 8; 37 static constexpr size_t kCommonFeedbackLength = 8;
38 void ParseCommonFeedback(const uint8_t* payload); 38 void ParseCommonFeedback(const uint8_t* payload);
39 void CreateCommonFeedback(uint8_t* payload) const; 39 void CreateCommonFeedback(uint8_t* payload) const;
40 40
41 private: 41 private:
42 uint32_t sender_ssrc_; 42 uint32_t sender_ssrc_;
43 uint32_t media_ssrc_; 43 uint32_t media_ssrc_;
44 }; 44 };
45 45
46 } // namespace rtcp 46 } // namespace rtcp
47 } // namespace webrtc 47 } // namespace webrtc
48 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_ 48 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PSFB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698