Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2348533002: Reland Replace interface VideoCapturerInput with VideoSinkInterface. (Closed)

Created:
4 years, 3 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace VideoCapturerInput with VideoSinkInterface. Adds new method VideoSendStream::SetSource(rtc::VideoSourceInterface* and VieEncoder::SetSource(rtc::VideoSourceInterface*) This is the first step needed in order for the ViEEncoder to request downscaling using rtc::VideoSinkWants instead of separately reporting CPU overuse and internally doing downscaling due to QP values This cl Revert "Revert of Replace interface VideoCapturerInput with VideoSinkInterface. (patchset #13 id:280001 of https://codereview.webrtc.org/2257413002/ )" This reverts commit 9fdbda6aa3f66ea872344c22e79b23361047cbab. and fix the problem in the original cl in video_quality_test.cc BUG=webrtc:5687 TBR=mflodman@webrtc.org Committed: https://crrev.com/a49cbd3e24b7ed151d4089b494c8135513292721 Cr-Commit-Position: refs/heads/master@{#14265}

Patch Set 1 : pure reland #

Patch Set 2 : Fix rtp timestamp in quality test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -227 lines) Patch
M webrtc/call/bitrate_estimator_tests.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 3 chunks +9 lines, -4 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 4 chunks +17 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 3 chunks +13 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 9 chunks +26 lines, -8 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/frame_generator.h View 3 chunks +24 lines, -3 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M webrtc/test/frame_generator_capturer.h View 4 chunks +9 lines, -5 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 5 chunks +25 lines, -15 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/vcm_capturer.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/test/vcm_capturer.cc View 4 chunks +18 lines, -8 lines 0 comments Download
M webrtc/test/video_capturer.h View 1 chunk +4 lines, -12 lines 0 comments Download
D webrtc/test/video_capturer.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 12 chunks +85 lines, -30 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +5 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.h View 7 chunks +15 lines, -8 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 5 chunks +62 lines, -10 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 10 chunks +22 lines, -19 lines 0 comments Download
M webrtc/video_send_stream.h View 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
perkj_webrtc
please?
4 years, 3 months ago (2016-09-16 09:31:35 UTC) #5
sprang_webrtc
lgtm
4 years, 3 months ago (2016-09-16 10:52:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2348533002/40001
4 years, 3 months ago (2016-09-16 10:52:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8415)
4 years, 3 months ago (2016-09-16 11:19:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2348533002/40001
4 years, 3 months ago (2016-09-16 12:46:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8426)
4 years, 3 months ago (2016-09-16 13:10:42 UTC) #15
perkj_webrtc
4 years, 3 months ago (2016-09-16 14:43:39 UTC) #16
perkj_webrtc
4 years, 3 months ago (2016-09-16 14:44:27 UTC) #18
perkj_webrtc
4 years, 3 months ago (2016-09-16 14:45:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2348533002/40001
4 years, 3 months ago (2016-09-16 14:45:22 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-16 14:53:45 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:53:58 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a49cbd3e24b7ed151d4089b494c8135513292721
Cr-Commit-Position: refs/heads/master@{#14265}

Powered by Google App Engine
This is Rietveld 408576698