Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2348133003: Roll chromium_revision cf9457edb7..cede888c27 (416297:419407) (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix remove ndk.gyp dependency #

Patch Set 3 : Remove tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M all.gyp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/system_wrappers/cpu_features_webrtc.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander_webrtc
We're getting close to the point where GYP is becoming useless :(
4 years, 3 months ago (2016-09-19 05:41:57 UTC) #2
kjellander_webrtc
On 2016/09/19 05:41:57, kjellander_webrtc wrote: > We're getting close to the point where GYP is ...
4 years, 3 months ago (2016-09-19 06:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2348133003/40001
4 years, 3 months ago (2016-09-19 06:51:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-19 06:59:01 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/afef413cc481dc4a28dff8bdf39cbbc59dfd255e Cr-Commit-Position: refs/heads/master@{#14282}
4 years, 3 months ago (2016-09-19 06:59:10 UTC) #10
kjellander_webrtc
4 years, 3 months ago (2016-09-19 08:55:01 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2348203002/ by kjellander@webrtc.org.

The reason for reverting is: Reverts a large number of tests downstream, will
need more investigation before relanding..

Powered by Google App Engine
This is Rietveld 408576698