Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2348123002: Revert of AcmReceiver: Look up last decoder in NetEq's table of decoders (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of AcmReceiver: Look up last decoder in NetEq's table of decoders (patchset #1 id:100001 of https://codereview.webrtc.org/2339953002/ ) Reason for revert: Seems to have broken Chromium tests. Original issue's description: > AcmReceiver: Look up last decoder in NetEq's table of decoders > > AcmReceiver::decoders_ is now one step closer to being unused. > > BUG=webrtc:5801 > > Committed: https://crrev.com/1e4d8b574cde64d93b98d89c7b817fb93185a307 > Cr-Commit-Position: refs/heads/master@{#14274} TBR=ossu@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5801 Committed: https://crrev.com/7a0f2c55f5d6128c643c86e08c3f8b0146edada6 Cr-Commit-Position: refs/heads/master@{#14279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -67 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 2 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 6 chunks +53 lines, -27 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
Created Revert of AcmReceiver: Look up last decoder in NetEq's table of decoders
4 years, 3 months ago (2016-09-18 12:35:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2348123002/1
4 years, 3 months ago (2016-09-18 12:35:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 12:35:55 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a0f2c55f5d6128c643c86e08c3f8b0146edada6 Cr-Commit-Position: refs/heads/master@{#14279}
4 years, 3 months ago (2016-09-18 12:36:05 UTC) #6
hlundin-webrtc
4 years, 3 months ago (2016-09-19 12:08:12 UTC) #7
Message was sent while issue was closed.
RS LGTM

Powered by Google App Engine
This is Rietveld 408576698