H264 codec: Check profile-level-id when matching

webrtc/media/base/codec.h

Index: webrtc/media/base/codec.h
diff --git a/webrtc/media/base/codec.h b/webrtc/media/base/codec.h
index 76a623a0de8af540da8eeb777c18437ad9fdd352..26bf79155b86e3958d11ce6e76d8aedf9935e010 100644
--- a/webrtc/media/base/codec.h
+++ b/webrtc/media/base/codec.h
@@ -81,6 +81,10 @@ struct Codec {
   // Find the parameter for |name| and write the value to |out|.
   bool GetParam(const std::string& name, std::string* out) const;
   bool GetParam(const std::string& name, int* out) const;
+  // Return the contained value for |name| if available, and |default_value|
+  // otherwise.
+  std::string GetParam(const std::string& name,
+                       const std::string& default_value) const;

[hta-webrtc, 2016/09/19 06:38:36]

Suggest not having this function. I've had this pair of functions for constraint
fetching, and decided it was a bad idea, since it required programmers to
remember two idioms instead of one.

Alternatively, name it GetParamOrDefault.

[magjed_webrtc, 2016/09/19 12:40:30]

Ok, I removed it from the public interface and made it a private helper function
in codec.cc. I hope that's ok since it's exactly the functionality I want and I
don't want to inline it four times.

The modern way of doing this would be to return an rtc::Optional<std::String>
(or std::Optional when that becomes available). Then we can write code like
GetParam(...).value_or(default_value).

 
   void SetParam(const std::string& name, const std::string& value);
   void SetParam(const std::string& name, int value);
@@ -155,6 +159,9 @@ struct VideoCodec : public Codec {
   VideoCodec(const VideoCodec& c);
   virtual ~VideoCodec() = default;
 
+  // Indicates if this codec is compatible with the specified codec.
+  bool Matches(const VideoCodec& codec) const;
+
   std::string ToString() const;
 
   VideoCodec& operator=(const VideoCodec& c);