Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2347403002: Merge AppRTCDemoJUnitTest into android_junit_tests target (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge AppRTCDemoJUnitTest into android_junit_tests target With the small number of tests these targets contain, it makes more sense to gather them into android_junit_tests instead, which was created to be a high-level target containing all the junit tests. BUG=chromium:647390 NOTRY=True Committed: https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4 Cr-Commit-Position: refs/heads/master@{#14292}

Patch Set 1 #

Patch Set 2 : Updated examples/androidjunit/README and removed old GYP target. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -39 lines) Patch
M webrtc/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/examples/androidjunit/README View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_webrtc
With this, we'll cover all the tests by adding android_junit_tests to the bots.
4 years, 3 months ago (2016-09-18 19:50:52 UTC) #2
sakal
It feels strange to have our top level test include tests for an example application. ...
4 years, 3 months ago (2016-09-19 08:57:26 UTC) #4
kjellander_webrtc
On 2016/09/19 08:57:26, sakal wrote: > It feels strange to have our top level test ...
4 years, 3 months ago (2016-09-19 09:17:47 UTC) #5
sakal
lgtm if Magnus approves combining these. Also, please update examples/androidjunit/README.
4 years, 3 months ago (2016-09-19 09:24:04 UTC) #6
magjed_webrtc
I'm fine with this change. lgtm.
4 years, 3 months ago (2016-09-19 09:27:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2347403002/20001
4 years, 3 months ago (2016-09-19 15:44:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 15:53:26 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 15:53:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4
Cr-Commit-Position: refs/heads/master@{#14292}

Powered by Google App Engine
This is Rietveld 408576698