Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2346763002: Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (Closed)

Created:
4 years, 3 months ago by Max Morin WebRTC
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. BUG=webrtc:3806 NOTRY=True Committed: https://crrev.com/100c9d02669910bce06099b3cc1eaad60fd661dd Cr-Commit-Position: refs/heads/master@{#14223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Max Morin WebRTC
Kjellander: PTAL
4 years, 3 months ago (2016-09-15 08:09:49 UTC) #3
kjellander_webrtc
lgtm, but I suggest a webrtc/base owner also takes a look just to be sure. ...
4 years, 3 months ago (2016-09-15 08:11:52 UTC) #4
Max Morin WebRTC
On 2016/09/15 08:11:52, kjellander_webrtc wrote: > lgtm, but I suggest a webrtc/base owner also takes ...
4 years, 3 months ago (2016-09-15 08:26:44 UTC) #7
henrika_webrtc
LGTM
4 years, 3 months ago (2016-09-15 08:28:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346763002/1
4 years, 3 months ago (2016-09-15 08:32:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 08:40:38 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/100c9d02669910bce06099b3cc1eaad60fd661dd Cr-Commit-Position: refs/heads/master@{#14223}
4 years, 3 months ago (2016-09-15 08:40:47 UTC) #14
Max Morin WebRTC
4 years, 3 months ago (2016-09-15 08:45:10 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2340253003/ by maxmorin@webrtc.org.

The reason for reverting is: Breaks iOS.

Powered by Google App Engine
This is Rietveld 408576698