Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2346453002: Use I420Buffer rather than VideoFrameBuffer when writing pixels. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use I420Buffer rather than VideoFrameBuffer when writing pixels. Prepares for deleting VideoFrameBuffer::MutableDataY{,U,V}. objc changes extracted from cl https://codereview.webrtc.org/2278883002/. BUG=webrtc:5921 Committed: https://crrev.com/edebf45712397f30c960fcba329784ba70819b9c Cr-Commit-Position: refs/heads/master@{#14236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nisse-webrtc
PTAL, see bug for context.
4 years, 3 months ago (2016-09-14 11:45:22 UTC) #2
tkchin_webrtc
lgtm
4 years, 3 months ago (2016-09-15 10:48:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346453002/1
4 years, 3 months ago (2016-09-15 10:51:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-15 12:52:08 UTC) #9
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-15 13:19:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346453002/1
4 years, 3 months ago (2016-09-15 14:04:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 14:20:43 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:20:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edebf45712397f30c960fcba329784ba70819b9c
Cr-Commit-Position: refs/heads/master@{#14236}

Powered by Google App Engine
This is Rietveld 408576698