Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2346173002: Revert of AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder (patchset #1 id:1 of https://codereview.webrtc.org/2341283002/ ) Reason for revert: Seems to have broken Chromium tests. Original issue's description: > AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder > > Instead of looking in AcmReceiver::decoders_, which we're trying to > get rid of. > > BUG=webrtc:5801 > > Committed: https://crrev.com/07772e4738ef8007280f97a0245eef34b9ca9391 > Cr-Commit-Position: refs/heads/master@{#14276} TBR=ossu@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5801 Committed: https://crrev.com/f62b82e95ffd720c454d668932f3694b9bd8e34b Cr-Commit-Position: refs/heads/master@{#14277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
Created Revert of AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder
4 years, 3 months ago (2016-09-18 12:32:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346173002/1
4 years, 3 months ago (2016-09-18 12:32:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 12:32:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f62b82e95ffd720c454d668932f3694b9bd8e34b Cr-Commit-Position: refs/heads/master@{#14277}
4 years, 3 months ago (2016-09-18 12:32:24 UTC) #6
hlundin-webrtc
4 years, 3 months ago (2016-09-19 12:07:29 UTC) #7
Message was sent while issue was closed.
RS LGTM

Powered by Google App Engine
This is Rietveld 408576698