Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2345743004: Remove Android tests GYP target. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove Android tests GYP target. BUG=webrtc:6365 NOTRY=True Committed: https://crrev.com/ea938c0c499913d25e536d475aad0c8ea4de282a Cr-Commit-Position: refs/heads/master@{#14257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -65 lines) Patch
D webrtc/build/android_tests.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/build/android_tests_noop.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/build/common.gypi View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
PTAL I am not sure if this is what you wanted?
4 years, 3 months ago (2016-09-16 10:53:51 UTC) #3
kjellander_webrtc
yes, exactly. Thanks! lgtm
4 years, 3 months ago (2016-09-16 11:10:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2345743004/1
4 years, 3 months ago (2016-09-16 12:13:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 12:21:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 12:21:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea938c0c499913d25e536d475aad0c8ea4de282a
Cr-Commit-Position: refs/heads/master@{#14257}

Powered by Google App Engine
This is Rietveld 408576698