Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2345213002:
Enable stabilization on Camera2. (Closed)
|
Created:
4 years, 3 months ago by sakal Modified:
4 years, 3 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnable stabilization on Camera2.
BUG=webrtc:6357
Committed: https://crrev.com/227c3c125e111c719c6825c4acfc7a88ced8810b
Cr-Commit-Position: refs/heads/master@{#14285}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Try to find ON value instead of finding not OFF value. #Patch Set 3 : Back to looping. #Patch Set 4 : Apparently the list of modes can be null. #Patch Set 5 : Video stabilization list should never be null, only optical. #Messages
Total messages: 23 (13 generated)
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/Camera2Session.java (right): https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/Camera2Session.java:226: private void chooseStabilizationMode(CaptureRequest.Builder captureRequestBuilder) { Can you comment that we prefer optical stabilization first, and secondly video stabilization, and that only one stabilization should be active at a time. https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/Camera2Session.java:230: if (mode != CaptureRequest.LENS_OPTICAL_STABILIZATION_MODE_OFF) { Can we use this instead: mode == CaptureRequest.LENS_OPTICAL_STABILIZATION_MODE_ON
https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/Camera2Session.java (right): https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/Camera2Session.java:226: private void chooseStabilizationMode(CaptureRequest.Builder captureRequestBuilder) { On 2016/09/16 08:37:05, magjed_webrtc wrote: > Can you comment that we prefer optical stabilization first, and secondly video > stabilization, and that only one stabilization should be active at a time. Done. https://codereview.webrtc.org/2345213002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/Camera2Session.java:230: if (mode != CaptureRequest.LENS_OPTICAL_STABILIZATION_MODE_OFF) { On 2016/09/16 08:37:05, magjed_webrtc wrote: > Can we use this instead: > mode == CaptureRequest.LENS_OPTICAL_STABILIZATION_MODE_ON Done.
lgtm
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2345213002/#ps60001 (title: "Apparently the list of modes can be null.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by sakal@webrtc.org
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2345213002/#ps80001 (title: "Video stabilization list should never be null, only optical.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Enable stabilization on Camera2. BUG=webrtc:6357 ========== to ========== Enable stabilization on Camera2. BUG=webrtc:6357 Committed: https://crrev.com/227c3c125e111c719c6825c4acfc7a88ced8810b Cr-Commit-Position: refs/heads/master@{#14285} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/227c3c125e111c719c6825c4acfc7a88ced8810b Cr-Commit-Position: refs/heads/master@{#14285} |
