Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2344923002: Revert of Replace interface VideoCapturerInput with VideoSinkInterface. (Closed)

Created:
4 years, 3 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace interface VideoCapturerInput with VideoSinkInterface. (patchset #13 id:280001 of https://codereview.webrtc.org/2257413002/ ) Reason for revert: Fails on Mac and Linux webrtc_perf_tests Original issue's description: > Replace VideoCapturerInput with VideoSinkInterface. > Adds new method VideoSendStream::SetSource(rtc::VideoSourceInterface* and VieEncoder::SetSource(rtc::VideoSourceInterface*) > > This is the first step needed in order for the ViEEncoder to request downscaling using rtc::VideoSinkWants instead of separately reporting CPU overuse and internally doing downscaling due to QP values. > > BUG=webrtc:5687 > // Android CQ seems broken. > NOTRY=true > > Committed: https://crrev.com/95a226f55ae7e32b83a6ba96232fb105a014dc6c > Cr-Commit-Position: refs/heads/master@{#14238} TBR=nisse@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/9fdbda6aa3f66ea872344c22e79b23361047cbab Cr-Commit-Position: refs/heads/master@{#14239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -397 lines) Patch
M webrtc/call/bitrate_estimator_tests.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 3 chunks +6 lines, -17 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 3 chunks +0 lines, -13 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 9 chunks +8 lines, -26 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/frame_generator.h View 2 chunks +3 lines, -24 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/test/frame_generator_capturer.h View 4 chunks +5 lines, -9 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 5 chunks +15 lines, -25 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/vcm_capturer.h View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/test/vcm_capturer.cc View 4 chunks +8 lines, -18 lines 0 comments Download
M webrtc/test/video_capturer.h View 1 chunk +12 lines, -4 lines 0 comments Download
A webrtc/test/video_capturer.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 12 chunks +31 lines, -81 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/video/vie_encoder.h View 7 chunks +8 lines, -15 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 5 chunks +10 lines, -62 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 10 chunks +27 lines, -30 lines 0 comments Download
M webrtc/video_send_stream.h View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perkj_webrtc
Created Revert of Replace interface VideoCapturerInput with VideoSinkInterface.
4 years, 3 months ago (2016-09-15 16:18:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344923002/1
4 years, 3 months ago (2016-09-15 16:19:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 16:19:24 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 16:19:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdbda6aa3f66ea872344c22e79b23361047cbab
Cr-Commit-Position: refs/heads/master@{#14239}

Powered by Google App Engine
This is Rietveld 408576698