Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2344633002: iSAC: Remove unnecessary WEBRTC_LINUX define (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iSAC: Remove unnecessary WEBRTC_LINUX define Similar to https://codereview.webrtc.org/1539883002 but for GN. This was discovered during GN vs GYP auditing. NOTRY=True BUG=webrtc:6323 Committed: https://crrev.com/f807a521fa900b62b23978c19231552154d711a1 Cr-Commit-Position: refs/heads/master@{#14220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-15 05:41:32 UTC) #2
ehmaldonado_webrtc
On 2016/09/15 05:41:32, kjellander_webrtc wrote: LGTM
4 years, 3 months ago (2016-09-15 05:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344633002/1
4 years, 3 months ago (2016-09-15 06:06:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 06:15:52 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 06:16:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f807a521fa900b62b23978c19231552154d711a1
Cr-Commit-Position: refs/heads/master@{#14220}

Powered by Google App Engine
This is Rietveld 408576698