Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2344623002: GN: Change group deps to public_deps. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Change group deps to public_deps. During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Committed: https://crrev.com/705ecc5dda2ddf3ba431aa4b8b3e34a0794bf28a Cr-Commit-Position: refs/heads/master@{#14222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/libjingle/xmllite/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/stats/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-15 05:42:08 UTC) #3
ehmaldonado_webrtc
On 2016/09/15 05:42:08, kjellander_webrtc wrote: LGTM
4 years, 3 months ago (2016-09-15 07:23:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344623002/1
4 years, 3 months ago (2016-09-15 07:52:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 07:53:29 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 07:53:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/705ecc5dda2ddf3ba431aa4b8b3e34a0794bf28a
Cr-Commit-Position: refs/heads/master@{#14222}

Powered by Google App Engine
This is Rietveld 408576698