Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2344383002: Reenabled the RtcEventLog unittests (Closed)

Created:
4 years, 3 months ago by skvlad
Modified:
4 years, 3 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reenabled the RtcEventLog unittests For some reason the RtcEventLog unit tests were not building and running. This CL adds these tests to the rtc_unittests target. They are only built if protobuf support is enabled. BUG=webrtc:6379 R=stefan@webrtc.org, terelius@webrtc.org Committed: https://crrev.com/e9cac751396d140e968192e763f540bd917cb551 Cr-Commit-Position: refs/heads/master@{#14295}

Patch Set 1 : Reenabled the RtcEventLog unittests #

Patch Set 2 : Added whitespace at the end of file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M webrtc/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/call/rtc_event_log_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/call/rtc_event_log_unittest_helper.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
skvlad
4 years, 3 months ago (2016-09-17 00:16:12 UTC) #3
terelius
lgtm
4 years, 3 months ago (2016-09-19 14:33:20 UTC) #4
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-19 15:44:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344383002/20001
4 years, 3 months ago (2016-09-19 17:43:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8484)
4 years, 3 months ago (2016-09-19 18:01:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344383002/40001
4 years, 3 months ago (2016-09-19 19:39:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-19 21:40:26 UTC) #14
skvlad
4 years, 3 months ago (2016-09-19 21:42:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
e9cac751396d140e968192e763f540bd917cb551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698