Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2344133002: Reland of Fix android_junit_tests and add a GN target for them. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fix android_junit_tests and add a GN target for them. (patchset #1 id:1 of https://codereview.webrtc.org/2341213003/ ) Reason for revert: Fix the issue. Original issue's description: > Revert of Fix android_junit_tests and add a GN target for them. (patchset #1 id:20001 of https://codereview.webrtc.org/2346793002/ ) > > Reason for revert: > Breaks WebRTC in Chrome on Android: > > https://build.chromium.org/p/chromium.webrtc.fyi/waterfall?builder=Android%20Builder%20(dbg) > > Original issue's description: > > Fix android_junit_tests and add a GN target for them. > > > > BUG=webrtc:6365 > > NOTRY=True > > > > Committed: https://crrev.com/bb716daea73889517f996aa29f867563ed63d58a > > Cr-Commit-Position: refs/heads/master@{#14241} > > TBR=magjed@webrtc.org,kjellander@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6365 > > Committed: https://crrev.com/9adb1ff9439aecf4e8ac3972a631bb74df2b6868 > Cr-Commit-Position: refs/heads/master@{#14253} TBR=magjed@webrtc.org,kjellander@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6365 Committed: https://crrev.com/51fe1d805d19bf7c79aad46049d040fae1ae6953 Cr-Commit-Position: refs/heads/master@{#14254}

Patch Set 1 #

Patch Set 2 : Move test inside rtc_include_tests. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sakal
Created Reland of Fix android_junit_tests and add a GN target for them.
4 years, 3 months ago (2016-09-16 11:18:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344133002/70001
4 years, 3 months ago (2016-09-16 11:25:37 UTC) #3
commit-bot: I haz the power
Failed to apply patch for webrtc/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-16 11:25:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2344133002/90001
4 years, 3 months ago (2016-09-16 11:27:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:90001)
4 years, 3 months ago (2016-09-16 11:28:05 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/51fe1d805d19bf7c79aad46049d040fae1ae6953 Cr-Commit-Position: refs/heads/master@{#14254}
4 years, 3 months ago (2016-09-16 11:28:10 UTC) #10
sakal
4 years, 3 months ago (2016-09-16 11:33:39 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:90001) has been created in
https://codereview.webrtc.org/2345163003/ by sakal@webrtc.org.

The reason for reverting is: Breaks bots..

Powered by Google App Engine
This is Rietveld 408576698