Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2343403002: Rename AppRTCDemo on Android and iOS to AppRTCMobile (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
tommi, kthelgason, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename AppRTCDemo on Android and iOS to AppRTCMobile The purpose is to make it clearer it is a mobile application. BUG=webrtc:6359 NOPRESUBMIT=true Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a Cr-Commit-Position: refs/heads/master@{#14356}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -7432 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 1 13 chunks +95 lines, -95 lines 0 comments Download
M webrtc/examples/androidapp/README View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/build.xml View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/res/values-v21/styles.xml View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/UnhandledExceptionHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidjunit/README View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidtests/README View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/examples/androidtests/build.xml View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDAppClient.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 chunk +0 lines, -846 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h View 1 chunk +0 lines, -57 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDAppEngineClient.h View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDAppEngineClient.m View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDBitrateTracker.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDBitrateTracker.m View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDCEODTURNClient.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDCEODTURNClient.m View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDJoinResponse.h View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDJoinResponse.m View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDJoinResponse+Internal.h View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDMessageResponse.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDMessageResponse.m View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDMessageResponse+Internal.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDRoomServerClient.h View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDSDPUtils.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDSDPUtils.m View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDSignalingChannel.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m View 1 chunk +0 lines, -161 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m View 1 chunk +0 lines, -300 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDTURNClient.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDWebSocketChannel.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ARDWebSocketChannel.m View 1 chunk +0 lines, -251 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.m View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.m View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCMediaConstraints+JSON.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCMediaConstraints+JSON.m View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCSessionDescription+JSON.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCSessionDescription+JSON.m View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/common/ARDUtilities.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/common/ARDUtilities.m View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDMainView.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDMainView.m View 1 chunk +0 lines, -392 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.h View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m View 1 chunk +0 lines, -211 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDStatsView.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDStatsView.m View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallView.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallView.m View 1 chunk +0 lines, -193 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.h View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m View 1 chunk +0 lines, -222 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/AppRTCDemo-Prefix.pch View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/Info.plist View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/UIImage+ARDUtilities.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/UIImage+ARDUtilities.m View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/main.m View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/Roboto-Regular.ttf View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/iPhone5@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/iPhone6@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/iPhone6p@3x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_call_end_black_24dp.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_call_end_black_24dp@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_clear_black_24dp.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_clear_black_24dp@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_surround_sound_black_24dp.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_surround_sound_black_24dp@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_switch_video_black_24dp.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/ic_switch_video_black_24dp@2x.png View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/ios/resources/mozart.mp3 View Binary file 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.h View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.m View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m View 1 chunk +0 lines, -328 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/Info.plist View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/mac/main.m View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm View 1 chunk +0 lines, -350 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/third_party/SocketRocket/LICENSE View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/third_party/SocketRocket/SRWebSocket.h View 1 chunk +0 lines, -132 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/third_party/SocketRocket/SRWebSocket.m View 1 chunk +0 lines, -1761 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDAppClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDAppClient.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDAppClient+Internal.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDBitrateTracker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDBitrateTracker.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDCEODTURNClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDCEODTURNClient.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDJoinResponse.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDJoinResponse.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDJoinResponse+Internal.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDMessageResponse.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDMessageResponse.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDMessageResponse+Internal.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDRoomServerClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDSignalingChannel.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDSignalingMessage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDSignalingMessage.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDStatsBuilder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDStatsBuilder.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDTURNClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDWebSocketChannel.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDWebSocketChannel.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCIceCandidate+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCIceCandidate+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCIceServer+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCIceServer+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCMediaConstraints+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCMediaConstraints+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCSessionDescription+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/RTCSessionDescription+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/common/ARDUtilities.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/common/ARDUtilities.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDAppDelegate.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDAppDelegate.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDMainView.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDMainView.m View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDStatsView.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDStatsView.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallViewController.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallViewController.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/AppRTCMobile-Prefix.pch View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/Info.plist View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/UIImage+ARDUtilities.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/UIImage+ARDUtilities.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/main.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/Roboto-Regular.ttf View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/iPhone5@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/iPhone6@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/iPhone6p@3x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_call_end_black_24dp@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_clear_black_24dp.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_clear_black_24dp@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_surround_sound_black_24dp@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/ic_switch_video_black_24dp@2x.png View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ios/resources/mozart.mp3 View Binary file 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/APPRTCAppDelegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/APPRTCAppDelegate.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/APPRTCViewController.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/APPRTCViewController.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/Info.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/mac/main.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/tests/ARDAppClientTest.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 9 chunks +94 lines, -94 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
kthelgason
This almost certainly requires a doc update on webrtc.org. At least to update target names ...
4 years, 3 months ago (2016-09-19 11:09:21 UTC) #3
magjed_webrtc
On 2016/09/19 11:09:21, kthelgason wrote: > This almost certainly requires a doc update on http://webrtc.org. ...
4 years, 3 months ago (2016-09-19 12:43:35 UTC) #5
magjed_webrtc
Please take a look. We should also update the documentation after this lands.
4 years, 3 months ago (2016-09-19 12:47:34 UTC) #6
kthelgason
On 2016/09/19 12:47:34, magjed_webrtc wrote: > Please take a look. We should also update the ...
4 years, 3 months ago (2016-09-19 13:09:03 UTC) #7
sakal
lgtm Personally, I would probably have kept the file structure to keep the CL smaller ...
4 years, 3 months ago (2016-09-19 13:10:17 UTC) #8
tommi
rs lgtm
4 years, 3 months ago (2016-09-22 09:16:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2343403002/1
4 years, 3 months ago (2016-09-22 11:23:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios64_gyp_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_rel/builds/779) mac_asan on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-09-22 11:25:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2343403002/20001
4 years, 3 months ago (2016-09-22 14:36:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8634)
4 years, 3 months ago (2016-09-22 14:55:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2343403002/20001
4 years, 3 months ago (2016-09-22 16:11:57 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 16:12:34 UTC) #23
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a Cr-Commit-Position: refs/heads/master@{#14356}
4 years, 3 months ago (2016-09-22 16:12:46 UTC) #25
magjed_webrtc
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.webrtc.org/2363773002/ by magjed@webrtc.org. ...
4 years, 3 months ago (2016-09-22 17:12:12 UTC) #26
magjed_webrtc
4 years, 3 months ago (2016-09-22 17:14:29 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2358133003/ by magjed@webrtc.org.

The reason for reverting is: Breaks internal project..

Powered by Google App Engine
This is Rietveld 408576698