Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2342913004: Removed bitrate_controller.h file reference from gn file. (Closed)

Created:
4 years, 3 months ago by charujain
Modified:
4 years, 3 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, kjellander_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed bitrate_controller.h file reference from gn file. BitrateAllocator was moved from BitrateController logic to Call in https://chromium.googlesource.com/external/webrtc/+/0e7e259ebd69993bb5670a991f43aa1b06c9bf9e BUG=None NOTRY=True Committed: https://crrev.com/b55c434c655323e6a5ddb99415b47dfa6c5725d7 Cr-Commit-Position: refs/heads/master@{#14267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/modules/bitrate_controller/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
charujain
4 years, 3 months ago (2016-09-16 13:26:24 UTC) #3
phoglund
lgtm
4 years, 3 months ago (2016-09-16 13:29:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342913004/1
4 years, 3 months ago (2016-09-16 13:29:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-16 15:30:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342913004/1
4 years, 3 months ago (2016-09-16 15:40:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 15:48:53 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 15:49:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b55c434c655323e6a5ddb99415b47dfa6c5725d7
Cr-Commit-Position: refs/heads/master@{#14267}

Powered by Google App Engine
This is Rietveld 408576698