Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2342823002: Disable all screen-capturer tests (Closed)

Created:
4 years, 3 months ago by stefan-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable all screen-capturer tests ScreenCapturerTest.CaptureUpdatedRegion* tests are flaky and are running in the wrong executable. BUG=webrtc:6366, chromium:647067 NOTRY=True Committed: https://crrev.com/0a6e0dc471a90229c4f9a5a876e4ffafc4233c97 Cr-Commit-Position: refs/heads/master@{#14232}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 1 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stefan-webrtc
PTAL.
4 years, 3 months ago (2016-09-15 11:56:39 UTC) #2
kjellander_webrtc
lgtm but I guess you need to TBR someone as well.
4 years, 3 months ago (2016-09-15 11:58:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342823002/20001
4 years, 3 months ago (2016-09-15 12:00:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 12:04:37 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:04:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a6e0dc471a90229c4f9a5a876e4ffafc4233c97
Cr-Commit-Position: refs/heads/master@{#14232}

Powered by Google App Engine
This is Rietveld 408576698