Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2342783003: Reland of Update test code to use I420Buffer when writing pixel data. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Update test code to use I420Buffer when writing pixel data. (patchset #1 id:1 of https://codereview.webrtc.org/2342123003/ ) Reason for revert: Intending to fix problem and reland. Original issue's description: > Revert of Update test code to use I420Buffer when writing pixel data. (patchset #5 id:80001 of https://codereview.webrtc.org/2333373007/ ) > > Reason for revert: > Fails 64-bit windows builds, it turns out I missed some of the needed int/size_t casts. Example https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release > > Hope our windows try bots get back in working shape soon. > > Original issue's description: > > Update test code to use I420Buffer when writing pixel data. > > > > VideoFrameBuffer and VideoFrame will become immutable. > > > > BUG=webrtc:5921 > > R=magjed@webrtc.org, phoglund@webrtc.org > > > > Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d > > Cr-Commit-Position: refs/heads/master@{#14249} > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5921 > > Committed: https://crrev.com/fbf14607267adf03d235273283ca452a1e564861 > Cr-Commit-Position: refs/heads/master@{#14251} TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5921 Committed: https://crrev.com/d21534a8cfe636bbcf3d7bb151945590abc92b2a Cr-Commit-Position: refs/heads/master@{#14258}

Patch Set 1 #

Patch Set 2 : Attempt to fix int/size_t issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -85 lines) Patch
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 1 chunk +37 lines, -37 lines 0 comments Download
M webrtc/test/fake_texture_frame.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 5 chunks +44 lines, -32 lines 0 comments Download
M webrtc/test/testsupport/metrics/video_metrics.cc View 1 3 chunks +35 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Reland of Update test code to use I420Buffer when writing pixel data.
4 years, 3 months ago (2016-09-16 09:31:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342783003/140001
4 years, 3 months ago (2016-09-16 12:38:31 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 3 months ago (2016-09-16 12:38:41 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d21534a8cfe636bbcf3d7bb151945590abc92b2a Cr-Commit-Position: refs/heads/master@{#14258}
4 years, 3 months ago (2016-09-16 12:38:53 UTC) #6
nisse-webrtc
4 years, 3 months ago (2016-09-16 12:44:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:140001) has been created in
https://codereview.webrtc.org/2343083002/ by nisse@webrtc.org.

The reason for reverting is: I was too impatient; this made android builds fail
instead. See
https://build.chromium.org/p/client.webrtc/builders/Linux32%20ARM/builds/585/...

.

Powered by Google App Engine
This is Rietveld 408576698