Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2342783002: Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True Committed: https://crrev.com/57b490004db110bfb26c0ff6636c45b0579d3833 Cr-Commit-Position: refs/heads/master@{#14261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-15 09:33:53 UTC) #3
kjellander_webrtc
Do you know how it can work without adding a dependency on robolectric? I guess ...
4 years, 3 months ago (2016-09-15 09:48:27 UTC) #5
sakal
On 2016/09/15 09:48:27, kjellander_webrtc wrote: > Do you know how it can work without adding ...
4 years, 3 months ago (2016-09-15 09:49:44 UTC) #6
kjellander_webrtc
On 2016/09/15 09:49:44, sakal wrote: > On 2016/09/15 09:48:27, kjellander_webrtc wrote: > > Do you ...
4 years, 3 months ago (2016-09-15 10:01:09 UTC) #7
kjellander_webrtc
On 2016/09/15 10:01:09, kjellander_webrtc wrote: > On 2016/09/15 09:49:44, sakal wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 10:11:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342783002/1
4 years, 3 months ago (2016-09-16 12:46:44 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-16 12:46:46 UTC) #13
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-16 12:59:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342783002/1
4 years, 3 months ago (2016-09-16 13:00:05 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 13:02:53 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 13:03:02 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57b490004db110bfb26c0ff6636c45b0579d3833
Cr-Commit-Position: refs/heads/master@{#14261}

Powered by Google App Engine
This is Rietveld 408576698