|
|
DescriptionChange AppRTCDemoJUnitTest to use LocalRobolectricTestRunner.
It was previously using org.robolectric.RobolectricTestRunner. Due to
changes in Chromium this no longer works. This CL fixes the issue.
BUG=webrtc:6363
NOTRY=True
Committed: https://crrev.com/57b490004db110bfb26c0ff6636c45b0579d3833
Cr-Commit-Position: refs/heads/master@{#14261}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 ========== to ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Do you know how it can work without adding a dependency on robolectric? I guess it doesn't matter, but is seems strange.
On 2016/09/15 09:48:27, kjellander_webrtc wrote: > Do you know how it can work without adding a dependency on robolectric? I guess > it doesn't matter, but is seems strange. The dependency is added by the junit_binary template.
On 2016/09/15 09:49:44, sakal wrote: > On 2016/09/15 09:48:27, kjellander_webrtc wrote: > > Do you know how it can work without adding a dependency on robolectric? I > guess > > it doesn't matter, but is seems strange. > > The dependency is added by the junit_binary template. Ah :) that explains it. I didn't dig that deep.
Description was changed from ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 ========== to ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True ==========
On 2016/09/15 10:01:09, kjellander_webrtc wrote: > On 2016/09/15 09:49:44, sakal wrote: > > On 2016/09/15 09:48:27, kjellander_webrtc wrote: > > > Do you know how it can work without adding a dependency on robolectric? I > > guess > > > it doesn't matter, but is seems strange. > > > > The dependency is added by the junit_binary template. > > Ah :) that explains it. I didn't dig that deep. Added NOTRY=True for you (but run a few Android compile trybots)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by sakal@webrtc.org
The CQ bit was checked by magjed@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True ========== to ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True ========== to ========== Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner. It was previously using org.robolectric.RobolectricTestRunner. Due to changes in Chromium this no longer works. This CL fixes the issue. BUG=webrtc:6363 NOTRY=True Committed: https://crrev.com/57b490004db110bfb26c0ff6636c45b0579d3833 Cr-Commit-Position: refs/heads/master@{#14261} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/57b490004db110bfb26c0ff6636c45b0579d3833 Cr-Commit-Position: refs/heads/master@{#14261} |