Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc

Issue 2342443005: Moved Opus-specific payload splitting into AudioDecoderOpus. (Closed)
Patch Set: Some small fixes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
index 82af0e9f06923df863cc4f96194464f46815e802..258776ff19086903170ed5da5de707d446b99d33 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
@@ -28,7 +28,7 @@
#include "webrtc/modules/audio_coding/neteq/mock/mock_dtmf_buffer.h"
#include "webrtc/modules/audio_coding/neteq/mock/mock_dtmf_tone_generator.h"
#include "webrtc/modules/audio_coding/neteq/mock/mock_packet_buffer.h"
-#include "webrtc/modules/audio_coding/neteq/mock/mock_payload_splitter.h"
+#include "webrtc/modules/audio_coding/neteq/mock/mock_red_payload_splitter.h"
#include "webrtc/modules/audio_coding/neteq/preemptive_expand.h"
#include "webrtc/modules/audio_coding/neteq/sync_buffer.h"
#include "webrtc/modules/audio_coding/neteq/timestamp_scaler.h"
@@ -124,11 +124,11 @@ class NetEqImplTest : public ::testing::Test {
packet_buffer_ = deps.packet_buffer.get();
if (use_mock_payload_splitter_) {
- std::unique_ptr<MockPayloadSplitter> mock(new MockPayloadSplitter);
+ std::unique_ptr<MockRedPayloadSplitter> mock(new MockRedPayloadSplitter);
mock_payload_splitter_ = mock.get();
- deps.payload_splitter = std::move(mock);
+ deps.red_payload_splitter = std::move(mock);
}
- payload_splitter_ = deps.payload_splitter.get();
+ red_payload_splitter_ = deps.red_payload_splitter.get();
deps.timestamp_scaler = std::unique_ptr<TimestampScaler>(
new TimestampScaler(*deps.decoder_database.get()));
@@ -197,8 +197,8 @@ class NetEqImplTest : public ::testing::Test {
MockPacketBuffer* mock_packet_buffer_ = nullptr;
PacketBuffer* packet_buffer_ = nullptr;
bool use_mock_packet_buffer_ = true;
- MockPayloadSplitter* mock_payload_splitter_ = nullptr;
- PayloadSplitter* payload_splitter_ = nullptr;
+ MockRedPayloadSplitter* mock_payload_splitter_ = nullptr;
+ RedPayloadSplitter* red_payload_splitter_ = nullptr;
bool use_mock_payload_splitter_ = true;
};
@@ -326,11 +326,6 @@ TEST_F(NetEqImplTest, InsertPacket) {
.WillOnce(Return(0));
}
- // Expectations for payload splitter.
- EXPECT_CALL(*mock_payload_splitter_, SplitFec(_, _))
- .Times(2)
- .WillRepeatedly(Return(PayloadSplitter::kOK));
-
// Insert first packet.
neteq_->InsertPacket(rtp_header, payload, kFirstReceiveTime);

Powered by Google App Engine
This is Rietveld 408576698