webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h - Issue 2342443005: Moved Opus-specific payload splitting into AudioDecoderOpus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h

Issue 2342443005: Moved Opus-specific payload splitting into AudioDecoderOpus. (Closed)

Patch Set: Forbade negative Packet priorities; PayloadSplitter -> RedPayloadSplitter; formatting/linting Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h

diff --git a/webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h b/webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h

index 1d2da4a7183eab0b4dc06ad4a8a15e77c5e401ba..577eecc535c9e160e67a223fb45ec7ef4747d76d 100644

--- a/webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h

+++ b/webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h

@@ -21,8 +21,7 @@ class AudioDecoderPcm16B final : public AudioDecoder {

AudioDecoderPcm16B(int sample_rate_hz, size_t num_channels);

void Reset() override;

std::vector<ParseResult> ParsePayload(rtc::Buffer&& payload,

- uint32_t timestamp,

- bool is_primary) override;

+ uint32_t timestamp) override;

int PacketDuration(const uint8_t* encoded, size_t encoded_len) const override;

int SampleRateHz() const override;

size_t Channels() const override;