Moved Opus-specific payload splitting into AudioDecoderOpus.

webrtc/modules/audio_coding/neteq/payload_splitter.h

Index: webrtc/modules/audio_coding/neteq/payload_splitter.h
diff --git a/webrtc/modules/audio_coding/neteq/payload_splitter.h b/webrtc/modules/audio_coding/neteq/payload_splitter.h
index a3e1b1d91c76bd047995407d0f8d80932941e4a4..feb175098c8559150df7898e53864da4e94d0e60 100644
--- a/webrtc/modules/audio_coding/neteq/payload_splitter.h
+++ b/webrtc/modules/audio_coding/neteq/payload_splitter.h
@@ -19,19 +19,14 @@ namespace webrtc {
 // Forward declarations.
 class DecoderDatabase;
 
-// This class handles splitting of payloads into smaller parts.
-
-// For RED and FEC the splitting is done internally. Other codecs' packets are
-// split by calling AudioDecoder::SplitPacket.
+// This class handles splitting of RED payloads into smaller parts.
+// Codec-specific packet splitting can be performed by
+// AudioDecoder::ParsePayload.
 class PayloadSplitter {

[kwiberg-webrtc, 2016/09/19 11:07:49]

+1 for making this RedPayloadSplitter. Or PayloadSplitterRed, for consistency
with Youtube Red...

[ossu, 2016/09/19 11:41:01]

Acknowledged.

  public:
   enum SplitterReturnCodes {
     kOK = 0,
-    kNoSplit = 1,
-    kFrameSplitError = -2,
-    kUnknownPayloadType = -3,
     kRedLengthMismatch = -4,
-    kFecSplitError = -5,
   };

[kwiberg-webrtc, 2016/09/19 11:07:49]

:-)

[ossu, 2016/09/19 11:41:01]

Yeah, maybe just have RedPayloadSplitter return a bool at this point.

[kwiberg-webrtc, 2016/09/19 11:55:16]

Yes. Or an enum class, but a bool should be enough.

 
   PayloadSplitter() {}
@@ -46,12 +41,6 @@ class PayloadSplitter {
   // Returns kOK or an error.
   virtual int SplitRed(PacketList* packet_list);
 
-  // Iterates through |packet_list| and, duplicate each audio payload that has
-  // FEC as new packet for redundant decoding. The decoder database is needed to
-  // get information about which payload type each packet contains.
-  virtual int SplitFec(PacketList* packet_list,
-                       DecoderDatabase* decoder_database);
-
   // Checks all packets in |packet_list|. Packets that are DTMF events or
   // comfort noise payloads are kept. Except that, only one single payload type
   // is accepted. Any packet with another payload type is discarded.