Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2342293002: [GN] Add missing framework headers (Closed)

Created:
4 years, 3 months ago by kthelgason
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[GN] Add missing framework headers This CL adds headers that are present in the /Headers directory but not included in the framework target. BUG=none NOTRY=true Committed: https://crrev.com/8fea1992f8b4c0f1c57f3ebae6f44f0f197551a4 Cr-Commit-Position: refs/heads/master@{#14413}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
kthelgason
4 years, 3 months ago (2016-09-16 07:40:04 UTC) #3
kjellander_webrtc
https://codereview.webrtc.org/2342293002/diff/1/webrtc/sdk/BUILD.gn File webrtc/sdk/BUILD.gn (right): https://codereview.webrtc.org/2342293002/diff/1/webrtc/sdk/BUILD.gn#newcode233 webrtc/sdk/BUILD.gn:233: "objc/Framework/Headers/WebRTC/RTCLogging.h", Since objc/Framework/Headers/WebRTC/RTCFileLogger.h is handled differently below (even if ...
4 years, 3 months ago (2016-09-18 17:45:38 UTC) #4
tkchin_webrtc
lgtm https://codereview.webrtc.org/2342293002/diff/1/webrtc/sdk/BUILD.gn File webrtc/sdk/BUILD.gn (right): https://codereview.webrtc.org/2342293002/diff/1/webrtc/sdk/BUILD.gn#newcode233 webrtc/sdk/BUILD.gn:233: "objc/Framework/Headers/WebRTC/RTCLogging.h", On 2016/09/18 17:45:38, kjellander_webrtc wrote: > Since ...
4 years, 2 months ago (2016-09-27 09:39:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342293002/1
4 years, 2 months ago (2016-09-28 09:01:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 09:06:57 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:07:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fea1992f8b4c0f1c57f3ebae6f44f0f197551a4
Cr-Commit-Position: refs/heads/master@{#14413}

Powered by Google App Engine
This is Rietveld 408576698