Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2342123003: Revert of Update test code to use I420Buffer when writing pixel data. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update test code to use I420Buffer when writing pixel data. (patchset #5 id:80001 of https://codereview.webrtc.org/2333373007/ ) Reason for revert: Fails 64-bit windows builds, it turns out I missed some of the needed int/size_t casts. Example https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release Hope our windows try bots get back in working shape soon. Original issue's description: > Update test code to use I420Buffer when writing pixel data. > > VideoFrameBuffer and VideoFrame will become immutable. > > BUG=webrtc:5921 > R=magjed@webrtc.org, phoglund@webrtc.org > > Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d > Cr-Commit-Position: refs/heads/master@{#14249} TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5921 Committed: https://crrev.com/fbf14607267adf03d235273283ca452a1e564861 Cr-Commit-Position: refs/heads/master@{#14251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -132 lines) Patch
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 chunk +41 lines, -41 lines 0 comments Download
M webrtc/test/fake_texture_frame.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/test/frame_generator.cc View 5 chunks +36 lines, -48 lines 0 comments Download
M webrtc/test/testsupport/metrics/video_metrics.cc View 3 chunks +14 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
Created Revert of Update test code to use I420Buffer when writing pixel data.
4 years, 3 months ago (2016-09-16 08:31:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342123003/1
4 years, 3 months ago (2016-09-16 08:31:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 08:32:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fbf14607267adf03d235273283ca452a1e564861 Cr-Commit-Position: refs/heads/master@{#14251}
4 years, 3 months ago (2016-09-16 08:32:17 UTC) #7
nisse-webrtc
4 years, 3 months ago (2016-09-16 09:31:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2342783003/ by nisse@webrtc.org.

The reason for reverting is: Intending to fix problem and reland..

Powered by Google App Engine
This is Rietveld 408576698