Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2342033002: MB: Change Android Clang to build shared instead of static. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Change Android Clang to build shared instead of static. A recent build error on Android revealed that we're always doing static builds for the Android Debug builders. This changes one to be building shared library instead (is_component_build=true), which should prevent such breakages in the future. BUG=webrtc:6360 NOTRY=True Committed: https://crrev.com/70d01242f8898aeb9dddfbbeaf3f22421479fe7c Cr-Commit-Position: refs/heads/master@{#14226}

Patch Set 1 #

Patch Set 2 : Renamed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/build/mb_config.pyl View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-15 09:55:21 UTC) #2
ehmaldonado_webrtc
On 2016/09/15 09:55:21, kjellander_webrtc wrote: Can you update the config name too?
4 years, 3 months ago (2016-09-15 10:32:32 UTC) #3
ehmaldonado_webrtc
On 2016/09/15 10:32:32, ehmaldonado_webrtc wrote: > On 2016/09/15 09:55:21, kjellander_webrtc wrote: > > Can you ...
4 years, 3 months ago (2016-09-15 10:33:33 UTC) #4
kjellander_webrtc
On 2016/09/15 10:33:33, ehmaldonado_webrtc wrote: > On 2016/09/15 10:32:32, ehmaldonado_webrtc wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 10:35:33 UTC) #5
ehmaldonado_webrtc
On 2016/09/15 10:35:33, kjellander_webrtc wrote: > On 2016/09/15 10:33:33, ehmaldonado_webrtc wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 10:37:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2342033002/20001
4 years, 3 months ago (2016-09-15 10:37:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 10:42:32 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:42:45 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70d01242f8898aeb9dddfbbeaf3f22421479fe7c
Cr-Commit-Position: refs/heads/master@{#14226}

Powered by Google App Engine
This is Rietveld 408576698