Add new decoding statistics for muted output

Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483

Committed: https://crrev.com/63489787a0d0b7e613e8be3d9d06959ebc2abc45
Cr-Commit-Position: refs/heads/master@{#14302}

[hlundin-webrtc, 2016-09-16 12:05:44]

Description was changed from

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606, b/31256483
==========

to

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606,b/31256483
==========

[hlundin-webrtc, 2016-09-16 12:05:44]

henrik.lundin@webrtc.org changed reviewers:
+ solenberg@webrtc.org, tommi@webrtc.org

[hlundin-webrtc, 2016-09-16 12:06:02]

Description was changed from

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606,b/31256483
==========

to

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483
==========

[hlundin-webrtc, 2016-09-16 12:07:28]

Patchset #1 (id:1) has been deleted

[hlundin-webrtc, 2016-09-16 13:02:38]

tommi, solenberg,

Please, take a look.

Thanks!

[tommi, 2016-09-16 13:36:56]

lgtm.  Out of curiosity, how long is "some time"? (see description)

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/call_statistics.cc (right):

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/call_statistics.cc:44: assert(false);
nit: if it's not too much trouble, it would be nice to switch asserts out for
RTC_DCHECKs.
also, should there be a default label?

[the sun, 2016-09-16 17:18:36]

lgtm

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right):

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/acm_receiver.cc:194:
call_stats_.DecodedByNetEq(audio_frame->speech_type_, *muted);
nit: DCHECK the pointer at function entry, since now you're dereffing it, not
just passing it on.

[the sun, 2016-09-16 17:19:12]

On 2016/09/16 17:18:36, the sun wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
> File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right):
> 
>
https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
> webrtc/modules/audio_coding/acm2/acm_receiver.cc:194:
> call_stats_.DecodedByNetEq(audio_frame->speech_type_, *muted);
> nit: DCHECK the pointer at function entry, since now you're dereffing it, not
> just passing it on.

Oh, and btw, thanks for updating all the tests!

[hlundin-webrtc, 2016-09-20 07:48:38]

Thanks! Will commit ps2.

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right):

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/acm_receiver.cc:194:
call_stats_.DecodedByNetEq(audio_frame->speech_type_, *muted);
On 2016/09/16 17:18:36, the sun wrote:
> nit: DCHECK the pointer at function entry, since now you're dereffing it, not
> just passing it on.

Done.

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/call_statistics.cc (right):

https://codereview.webrtc.org/2341293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/call_statistics.cc:44: assert(false);
On 2016/09/16 13:36:56, tommi (webrtc) wrote:
> nit: if it's not too much trouble, it would be nice to switch asserts out for
> RTC_DCHECKs.
Done.

> also, should there be a default label?
No, not here. We're switching on an enum, and if we don't have a default label,
the compiler forces us to deal with all values of the enum. Add a default label,
and that help is no more.

[hlundin-webrtc, 2016-09-20 07:48:43]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-09-20 07:48:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2341293002/#ps40001 (title:
"Updates after reviews")

[commit-bot: I haz the power, 2016-09-20 07:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 08:47:15]

Description was changed from

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483
==========

to

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483
==========

[commit-bot: I haz the power, 2016-09-20 08:47:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-20 08:47:21]

Description was changed from

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483
==========

to

==========
Add new decoding statistics for muted output

This change adds a new statistic for logging how many calls to
NetEq::GetAudio resulted in a "muted output". A muted output happens
if the packet stream has been dead for some time (and the last decoded
packet was not comfort noise).

BUG=webrtc:5606
BUG=b/31256483

Committed: https://crrev.com/63489787a0d0b7e613e8be3d9d06959ebc2abc45
Cr-Commit-Position: refs/heads/master@{#14302}
==========

[commit-bot: I haz the power, 2016-09-20 08:47:25]

Patchset 2 (id:??) landed as
https://crrev.com/63489787a0d0b7e613e8be3d9d06959ebc2abc45
Cr-Commit-Position: refs/heads/master@{#14302}