Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2341283002: AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder Instead of looking in AcmReceiver::decoders_, which we're trying to get rid of. BUG=webrtc:5801 Committed: https://crrev.com/07772e4738ef8007280f97a0245eef34b9ca9391 Cr-Commit-Position: refs/heads/master@{#14276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 4 chunks +10 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-09-16 12:09:27 UTC) #2
ossu
lgtm
4 years, 3 months ago (2016-09-16 12:11:55 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2342313002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-17 15:58:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2341283002/1
4 years, 3 months ago (2016-09-17 17:48:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 18:30:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/07772e4738ef8007280f97a0245eef34b9ca9391 Cr-Commit-Position: refs/heads/master@{#14276}
4 years, 3 months ago (2016-09-17 18:30:40 UTC) #11
kwiberg-webrtc
4 years, 3 months ago (2016-09-18 12:32:01 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2346173002/ by kwiberg@webrtc.org.

The reason for reverting is: Seems to have broken Chromium tests..

Powered by Google App Engine
This is Rietveld 408576698