Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2341213003: Revert of Fix android_junit_tests and add a GN target for them. (Closed)

Created:
4 years, 3 months ago by henrika_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix android_junit_tests and add a GN target for them. (patchset #1 id:20001 of https://codereview.webrtc.org/2346793002/ ) Reason for revert: Breaks WebRTC in Chrome on Android: https://build.chromium.org/p/chromium.webrtc.fyi/waterfall?builder=Android%20Builder%20(dbg) Original issue's description: > Fix android_junit_tests and add a GN target for them. > > BUG=webrtc:6365 > NOTRY=True > > Committed: https://crrev.com/bb716daea73889517f996aa29f867563ed63d58a > Cr-Commit-Position: refs/heads/master@{#14241} TBR=magjed@webrtc.org,kjellander@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6365 Committed: https://crrev.com/9adb1ff9439aecf4e8ac3972a631bb74df2b6868 Cr-Commit-Position: refs/heads/master@{#14253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M webrtc/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika_webrtc
Created Revert of Fix android_junit_tests and add a GN target for them.
4 years, 3 months ago (2016-09-16 11:11:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2341213003/1
4 years, 3 months ago (2016-09-16 11:11:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 11:11:54 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9adb1ff9439aecf4e8ac3972a631bb74df2b6868 Cr-Commit-Position: refs/heads/master@{#14253}
4 years, 3 months ago (2016-09-16 11:12:03 UTC) #7
sakal
4 years, 3 months ago (2016-09-16 11:18:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2344133002/ by sakal@webrtc.org.

The reason for reverting is: Fix the issue..

Powered by Google App Engine
This is Rietveld 408576698