Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Side by Side Diff: webrtc/common_video/i420_buffer_pool.cc

Issue 2341113005: I420BufferPool: Replace SequencedTaskChecker with RaceChecker (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/common_video/include/i420_buffer_pool.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/common_video/include/i420_buffer_pool.h" 11 #include "webrtc/common_video/include/i420_buffer_pool.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 14
15 namespace webrtc { 15 namespace webrtc {
16 16
17 I420BufferPool::I420BufferPool(bool zero_initialize) 17 I420BufferPool::I420BufferPool(bool zero_initialize)
18 : zero_initialize_(zero_initialize) { 18 : zero_initialize_(zero_initialize) {}
19 sequenced_checker_.Detach();
20 }
21 19
22 void I420BufferPool::Release() { 20 void I420BufferPool::Release() {
23 sequenced_checker_.Detach();
24 buffers_.clear(); 21 buffers_.clear();
25 } 22 }
26 23
27 rtc::scoped_refptr<I420Buffer> I420BufferPool::CreateBuffer(int width, 24 rtc::scoped_refptr<I420Buffer> I420BufferPool::CreateBuffer(int width,
28 int height) { 25 int height) {
29 RTC_DCHECK(sequenced_checker_.CalledSequentially()); 26 RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);
30 // Release buffers with wrong resolution. 27 // Release buffers with wrong resolution.
31 for (auto it = buffers_.begin(); it != buffers_.end();) { 28 for (auto it = buffers_.begin(); it != buffers_.end();) {
32 if ((*it)->width() != width || (*it)->height() != height) 29 if ((*it)->width() != width || (*it)->height() != height)
33 it = buffers_.erase(it); 30 it = buffers_.erase(it);
34 else 31 else
35 ++it; 32 ++it;
36 } 33 }
37 // Look for a free buffer. 34 // Look for a free buffer.
38 for (const rtc::scoped_refptr<PooledI420Buffer>& buffer : buffers_) { 35 for (const rtc::scoped_refptr<PooledI420Buffer>& buffer : buffers_) {
39 // If the buffer is in use, the ref count will be >= 2, one from the list we 36 // If the buffer is in use, the ref count will be >= 2, one from the list we
40 // are looping over and one from the application. If the ref count is 1, 37 // are looping over and one from the application. If the ref count is 1,
41 // then the list we are looping over holds the only reference and it's safe 38 // then the list we are looping over holds the only reference and it's safe
42 // to reuse. 39 // to reuse.
43 if (buffer->HasOneRef()) 40 if (buffer->HasOneRef())
44 return buffer; 41 return buffer;
45 } 42 }
46 // Allocate new buffer. 43 // Allocate new buffer.
47 rtc::scoped_refptr<PooledI420Buffer> buffer = 44 rtc::scoped_refptr<PooledI420Buffer> buffer =
48 new PooledI420Buffer(width, height); 45 new PooledI420Buffer(width, height);
49 if (zero_initialize_) 46 if (zero_initialize_)
50 buffer->InitializeData(); 47 buffer->InitializeData();
51 buffers_.push_back(buffer); 48 buffers_.push_back(buffer);
52 return buffer; 49 return buffer;
53 } 50 }
54 51
55 } // namespace webrtc 52 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/common_video/include/i420_buffer_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698