Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2340773003: GYP: Remove targets inside include_tests==1 that are converted to GN. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, zhuangzesen_agora.io, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, mflodman, perkj_webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GYP: Remove targets inside include_tests==1 that are converted to GN. Remove a large number of targets that are no longer built, to reduce maintenance. Only targets that have a GN version were removed. BUG=webrtc:6323 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/17f008bf33547f8957a9aead36e4609f80955edd Cr-Commit-Position: refs/heads/master@{#14231}

Patch Set 1 #

Patch Set 2 : Removed more and all isolate files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4376 lines) Patch
M all.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/api/api_tests.gyp View 1 chunk +0 lines, -204 lines 0 comments Download
D webrtc/api/peerconnection_unittests.isolate View 1 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/api/peerconnection_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/build/android_tests.gyp View 2 chunks +0 lines, -254 lines 0 comments Download
M webrtc/build/android_tests_noop.gyp View 1 chunk +0 lines, -60 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/common_audio/common_audio_unittests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/common_audio/common_audio_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/common_video/common_video_unittests.gyp View 1 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/common_video/common_video_unittests.isolate View 1 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/common_video/common_video_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -179 lines 0 comments Download
D webrtc/media/rtc_media_unittests.isolate View 1 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/modules/audio_codec_speed_tests.isolate View 1 1 chunk +0 lines, -33 lines 0 comments Download
D webrtc/modules/audio_codec_speed_tests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +0 lines, -75 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/modules/audio_decoder_unittests.isolate View 1 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/modules/audio_decoder_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_device/audio_device.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/modules/audio_device_tests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -787 lines 0 comments Download
D webrtc/modules/modules_tests.isolate View 1 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/modules/modules_tests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/modules/modules_unittests.isolate View 1 1 chunk +0 lines, -153 lines 0 comments Download
D webrtc/modules/modules_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/modules/video_capture/video_capture_tests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/modules/video_render_tests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/pc/rtc_pc_unittests.isolate View 1 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/rtc_unittests.isolate View 1 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/rtc_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/stats/stats.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/system_wrappers/system_wrappers_tests.gyp View 1 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/system_wrappers/system_wrappers_unittests.isolate View 1 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/system_wrappers/system_wrappers_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/test/test.gyp View 2 chunks +0 lines, -87 lines 0 comments Download
D webrtc/test/test_support_unittests.isolate View 1 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/test/test_support_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 chunk +0 lines, -134 lines 0 comments Download
D webrtc/tools/tools_unittests.isolate View 1 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/tools/tools_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/video_engine_tests.isolate View 1 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/video_engine_tests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/voice_engine/voe_auto_test.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 2 chunks +0 lines, -191 lines 0 comments Download
D webrtc/voice_engine/voice_engine_unittests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/voice_engine/voice_engine_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/webrtc_nonparallel_tests.isolate View 1 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/webrtc_nonparallel_tests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/webrtc_perf_tests.isolate View 1 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/webrtc_perf_tests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 3 chunks +0 lines, -581 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-15 09:19:43 UTC) #3
kjellander_webrtc
On 2016/09/15 09:19:43, kjellander_webrtc wrote: Yay, 3081 lines of GYP going away!
4 years, 3 months ago (2016-09-15 09:20:15 UTC) #4
kjellander_webrtc
On 2016/09/15 09:20:15, kjellander_webrtc wrote: > On 2016/09/15 09:19:43, kjellander_webrtc wrote: > > Yay, 3081 ...
4 years, 3 months ago (2016-09-15 09:25:14 UTC) #5
ehmaldonado_webrtc
On 2016/09/15 09:25:14, kjellander_webrtc wrote: > On 2016/09/15 09:20:15, kjellander_webrtc wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 10:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340773003/20001
4 years, 3 months ago (2016-09-15 11:36:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8375)
4 years, 3 months ago (2016-09-15 11:48:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340773003/20001
4 years, 3 months ago (2016-09-15 11:57:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 11:57:40 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 11:57:45 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17f008bf33547f8957a9aead36e4609f80955edd
Cr-Commit-Position: refs/heads/master@{#14231}

Powered by Google App Engine
This is Rietveld 408576698