Add AlrDetector

webrtc/modules/pacing/paced_sender_unittest.cc

Index: webrtc/modules/pacing/paced_sender_unittest.cc
diff --git a/webrtc/modules/pacing/paced_sender_unittest.cc b/webrtc/modules/pacing/paced_sender_unittest.cc
index 861452567f8d018a070ee8987a290bffdac3d54b..881076e701888c7150156d84685c6e85e289219f 100644
--- a/webrtc/modules/pacing/paced_sender_unittest.cc
+++ b/webrtc/modules/pacing/paced_sender_unittest.cc
@@ -109,7 +109,7 @@ class PacedSenderTest : public ::testing::Test {
   PacedSenderTest() : clock_(123456) {
     srand(0);
     // Need to initialize PacedSender after we initialize clock.
-    send_bucket_.reset(new PacedSender(&clock_, &callback_));
+    send_bucket_.reset(new PacedSender(&clock_, &callback_, nullptr));

[philipel, 2016/09/19 11:25:23]

PacingObserver can't be null right?

I think we should check in PacedSender::Process if the PacingObserver is not
null and only then do the callback. Then we can add a ctor to PacedSender with
the old signature.

[Irfan, 2016/09/19 22:15:03]

Done.

     send_bucket_->CreateProbeCluster(900000, 6);
     send_bucket_->CreateProbeCluster(1800000, 5);
     // Default to bitrate probing disabled for testing purposes. Probing tests
@@ -414,7 +414,7 @@ TEST_F(PacedSenderTest, VerifyAverageBitrateVaryingMediaPayload) {
   const int kTimeStep = 5;
   const int64_t kBitrateWindow = 10000;
   PacedSenderPadding callback;
-  send_bucket_.reset(new PacedSender(&clock_, &callback));
+  send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr));
   send_bucket_->SetProbingEnabled(false);
   send_bucket_->SetEstimatedBitrate(kTargetBitrateBps);
 
@@ -815,7 +815,7 @@ TEST_F(PacedSenderTest, ProbingWithInitialFrame) {
   std::list<int> expected_deltas_list(expected_deltas,
                                       expected_deltas + kNumDeltas);
   PacedSenderProbing callback(expected_deltas_list, &clock_);
-  send_bucket_.reset(new PacedSender(&clock_, &callback));
+  send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr));
   send_bucket_->CreateProbeCluster(900000, 6);
   send_bucket_->CreateProbeCluster(1800000, 5);
   send_bucket_->SetEstimatedBitrate(kInitialBitrateBps);
@@ -847,7 +847,7 @@ TEST_F(PacedSenderTest, ProbingWithTooSmallInitialFrame) {
   std::list<int> expected_deltas_list(expected_deltas,
                                       expected_deltas + kNumDeltas);
   PacedSenderProbing callback(expected_deltas_list, &clock_);
-  send_bucket_.reset(new PacedSender(&clock_, &callback));
+  send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr));
   send_bucket_->CreateProbeCluster(900000, 6);
   send_bucket_->CreateProbeCluster(1800000, 5);
   send_bucket_->SetEstimatedBitrate(kInitialBitrateBps);