Split RtcpReceiver::HandleSenderReceiverReport into two functions

Split RtcpReceiver::HandleSenderReceiverReport into two functions
as a preparation to replace parsing implementation

BUG=webrtc:5260
R=philipel@webrtc.org

Committed: https://crrev.com/91511f13e1b07c8b143664c14147ca556c594ca7
Cr-Commit-Position: refs/heads/master@{#14237}

[danilchap, 2016-09-14 11:45:32]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[danilchap, 2016-09-14 11:45:33]

To make https://codereview.webrtc.org/2316093002/ more reviewable slicing out
this change

[philipel, 2016-09-15 11:58:20]

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:404: remoteSSRC)  // have I
received RTP packets from this party
format

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:425:
rtcpPacketInformation.rtcpPacketTypeFlags |= kRtcpRr;
This line look suspicious, do we say that this rtcp packet contains a receiver
report or whats going on?

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:136: RTCPUtility::RTCPParserV2&
rtcpParser,
Mark arguments as const or change them to pointers.

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:141: RTCPUtility::RTCPParserV2&
rtcpParser,
Ditto

[danilchap, 2016-09-15 12:17:30]

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:404: remoteSSRC)  // have I
received RTP packets from this party
On 2016/09/15 11:58:19, philipel wrote:
> format

Done.

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:425:
rtcpPacketInformation.rtcpPacketTypeFlags |= kRtcpRr;
On 2016/09/15 11:58:19, philipel wrote:
> This line look suspicious, do we say that this rtcp packet contains a receiver
> report or whats going on? 

This behavior is unchanged.
Treat sender report as receiver report if it come from unexpected ssrc.
Means still collect report blocks and notify interested observes about them.
Comment about it moved closer to this line.

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:136: RTCPUtility::RTCPParserV2&
rtcpParser,
On 2016/09/15 11:58:19, philipel wrote:
> Mark arguments as const or change them to pointers.

Acknowledged.
In one or two CLs this particular argument will be replaced with a different one
(sure it will follow style, will be const&).
Draft is linked from this CL.
Changing it in this CL would generate too many offtopic changes.

https://codereview.webrtc.org/2340763002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:141: RTCPUtility::RTCPParserV2&
rtcpParser,
On 2016/09/15 11:58:19, philipel wrote:
> Ditto

Acknowledged.

[philipel, 2016-09-15 12:32:27]

lgtm

[danilchap, 2016-09-15 14:24:45]

Description was changed from

==========
Split RtcpReceiver::HandleSenderReceiverReport into two functions
as a preparation to replace parsing implementation

BUG=webrtc:5260
==========

to

==========
Split RtcpReceiver::HandleSenderReceiverReport into two functions
as a preparation to replace parsing implementation

BUG=webrtc:5260
R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/91511f13e1b07c8b143664c14...
==========

[commit-bot: I haz the power, 2016-09-15 14:24:47]

Description was changed from

==========
Split RtcpReceiver::HandleSenderReceiverReport into two functions
as a preparation to replace parsing implementation

BUG=webrtc:5260
R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/91511f13e1b07c8b143664c14...
==========

to

==========
Split RtcpReceiver::HandleSenderReceiverReport into two functions
as a preparation to replace parsing implementation

BUG=webrtc:5260
R=philipel@webrtc.org

Committed: https://crrev.com/91511f13e1b07c8b143664c14147ca556c594ca7
Cr-Commit-Position: refs/heads/master@{#14237}
==========

[danilchap, 2016-09-15 14:24:47]

Committed patchset #3 (id:40001) manually as
91511f13e1b07c8b143664c14147ca556c594ca7 (presubmit successful).