Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2340753002: GN: Declare resources for targets. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Declare resources for targets. Declare resources for GN targets so that they can be isolated NOTRY=True BUG=chromium:497757 Committed: https://crrev.com/3a7f35b1c4abb7d08a41d79098e7f54a24a70783 Cr-Commit-Position: refs/heads/master@{#14210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -175 lines) Patch
M webrtc/BUILD.gn View 5 chunks +20 lines, -24 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/media/BUILD.gn View 2 chunks +11 lines, -12 lines 0 comments Download
M webrtc/modules/BUILD.gn View 5 chunks +112 lines, -114 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/test/BUILD.gn View 2 chunks +10 lines, -12 lines 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-14 11:27:21 UTC) #3
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-14 11:54:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340753002/1
4 years, 3 months ago (2016-09-14 12:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 12:10:05 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:10:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a7f35b1c4abb7d08a41d79098e7f54a24a70783
Cr-Commit-Position: refs/heads/master@{#14210}

Powered by Google App Engine
This is Rietveld 408576698