[GN] Add rtc_sdk_framework_objc target to GN

webrtc/sdk/BUILD.gn

 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
-import("//build/config/mac/mac_sdk.gni")
+if (is_mac) {
+  import("//build/config/mac/mac_sdk.gni")
+  import("//build/config/mac/rules.gni")
+}
+if (is_ios) {
+  import("//build/config/ios/rules.gni")
+}
 
 if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
   config("rtc_sdk_common_objc_config") {
     include_dirs = [
       "objc/Framework/Classes",
       "objc/Framework/Headers",
     ]
   }
 
   rtc_source_set("rtc_sdk_common_objc") {
@@ skipping 182 matching lines @@
       "../api:libjingle_peerconnection",
     ]
 
     if (rtc_build_libyuv) {
       deps += [ "$rtc_libyuv_dir" ]
       public_deps = [
         "$rtc_libyuv_dir",
       ]
     }
   }
+  if (is_mac) {
+    mac_framework_bundle("rtc_sdk_framework_objc") {
+      info_plist = "objc/Framework/Info.plist"
+      output_name = "WebRTC"
 
-  # TODO(tkchin): Add the rtc_sdk_framework_objc target.
+      sources = [
+        "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h",
+        "objc/Framework/Headers/WebRTC/RTCAudioSource.h",
+        "objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
+        "objc/Framework/Headers/WebRTC/RTCConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannel.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDispatcher.h",
+        "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
+        "objc/Framework/Headers/WebRTC/RTCFieldTrials.h",
+        "objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
+        "objc/Framework/Headers/WebRTC/RTCIceServer.h",
+        "objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
+        "objc/Framework/Headers/WebRTC/RTCMacros.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaSource.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStream.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h",
+        "objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnection.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpReceiver.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpSender.h",
+        "objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoSource.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
+        "objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
+        "objc/Framework/Headers/WebRTC/WebRTC.h",
+      ]
+
+      if (!build_with_chromium) {
+        sources += [ "objc/Framework/Headers/WebRTC/RTCFileLogger.h" ]
+      }
+
+      deps = [
+        ":rtc_sdk_peerconnection_objc",
+        "//webrtc/system_wrappers:field_trial_default",
+        "//webrtc/system_wrappers:metrics_default",
+      ]
+
+      libs = [
+        "AVFoundation.framework",
+        "AudioToolbox.framework",
+        "CoreGraphics.framework",
+        "CoreMedia.framework",
+        "GLKit.framework",
+        "VideoToolbox.framework",
+      ]
+
+      configs += [
+        "..:common_objc",
+        "//build/config/compiler:enable_arc",
+      ]
+
+      public_configs = [ ":rtc_sdk_common_objc_config" ]
+
+      if (is_clang) {
+        # Suppress warnings from the Chromium Clang plugins.
+        # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+        configs -= [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+  }
+  if (is_ios) {
+    ios_framework_bundle("rtc_sdk_framework_objc") {
+      info_plist = "objc/Framework/Info.plist"
+      output_name = "WebRTC"
+
+      sources = [
+        "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h",

[kjellander_webrtc, 2016/09/14 09:14:07]

Can you sort these lists alphabetically, extract them into a variable and use
that, since it looks very much the same for sources and public_headers?

I guess make a common_headers variable, which does not include
objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h for iOS, then add that header
for Mac only.
e.g.

Outer scope:
common_objc_headers = [......]

Mac:
sources = common_objc_headers +
"objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h"

iOS:
sources = common_objc_headers
public_headers = common_objc_headers

+        "objc/Framework/Headers/WebRTC/RTCAudioSource.h",
+        "objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
+        "objc/Framework/Headers/WebRTC/RTCConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannel.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDispatcher.h",
+        "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
+        "objc/Framework/Headers/WebRTC/RTCFieldTrials.h",
+        "objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
+        "objc/Framework/Headers/WebRTC/RTCIceServer.h",
+        "objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
+        "objc/Framework/Headers/WebRTC/RTCMacros.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaSource.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStream.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnection.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpReceiver.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpSender.h",
+        "objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoSource.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
+        "objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
+        "objc/Framework/Headers/WebRTC/WebRTC.h",
+      ]
+
+      public_headers = [
+        "objc/Framework/Headers/WebRTC/RTCAudioSource.h",
+        "objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h",
+        "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
+        "objc/Framework/Headers/WebRTC/RTCConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannel.h",
+        "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
+        "objc/Framework/Headers/WebRTC/RTCDispatcher.h",
+        "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
+        "objc/Framework/Headers/WebRTC/RTCFieldTrials.h",
+        "objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
+        "objc/Framework/Headers/WebRTC/RTCIceServer.h",
+        "objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
+        "objc/Framework/Headers/WebRTC/RTCMacros.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaSource.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStream.h",
+        "objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
+        "objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnection.h",
+        "objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpParameters.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpReceiver.h",
+        "objc/Framework/Headers/WebRTC/RTCRtpSender.h",
+        "objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoSource.h",
+        "objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
+        "objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
+        "objc/Framework/Headers/WebRTC/WebRTC.h",
+      ]
+
+      if (!build_with_chromium) {
+        sources += [ "objc/Framework/Headers/WebRTC/RTCFileLogger.h" ]
+        public_headers += [ "objc/Framework/Headers/WebRTC/RTCFileLogger.h" ]
+      }
+
+      deps = [
+        ":rtc_sdk_peerconnection_objc",
+        "//webrtc/system_wrappers:field_trial_default",
+        "//webrtc/system_wrappers:metrics_default",
+      ]
+
+      libs = [
+        "AVFoundation.framework",
+        "AudioToolbox.framework",
+        "CoreGraphics.framework",
+        "CoreMedia.framework",
+        "VideoToolbox.framework",
+      ]
+
+      configs += [
+        "..:common_objc",
+        "//build/config/compiler:enable_arc",
+      ]
+
+      public_configs = [ ":rtc_sdk_common_objc_config" ]
+
+      if (is_clang) {
+        # Suppress warnings from the Chromium Clang plugins.
+        # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+        configs -= [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+  }
 }