Removed the const char* (StaticString) type from RTCStatsMember.

Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True

Committed: https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
Cr-Commit-Position: refs/heads/master@{#14235}

[hbos, 2016-09-15 10:52:48]

hbos@webrtc.org changed reviewers:
+ nisse@webrtc.org

[hbos, 2016-09-15 10:52:48]

Please take a look, nisse.

[nisse-webrtc, 2016-09-15 11:19:02]

LGTM. If you agree about const, feel free to fix it now or in a separate cl,
whatever you find best.

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc
File webrtc/stats/rtcstats.cc (left):

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc#oldc...
webrtc/stats/rtcstats.cc:109: value_);
Maybe this should be const std::string? If I understand this correctly, this is
for consumers of stats, and they shouldn't modify the data in-place, right?

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc#oldc...
webrtc/stats/rtcstats.cc:129: std::vector<std::string>, kSequenceString, true,
false,
And similarly for sequences, const std::vector, and in this case const
std::vector<const std::string>.

[hbos, 2016-09-15 12:19:56]

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc
File webrtc/stats/rtcstats.cc (left):

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc#oldc...
webrtc/stats/rtcstats.cc:109: value_);
On 2016/09/15 11:19:02, nisse-webrtc wrote:
> Maybe this should be const std::string? If I understand this correctly, this
is
> for consumers of stats, and they shouldn't modify the data in-place, right?

Stats are created with non-const RTCStats objects, and consumed with const
RTCStats references. So non-const type T is correct (same as all the other
types).

*stats.foo will return const std::string& or std::string depending on if stats
(and thus stats.foo) is const or not. :)

https://codereview.webrtc.org/2340303002/diff/1/webrtc/stats/rtcstats.cc#oldc...
webrtc/stats/rtcstats.cc:129: std::vector<std::string>, kSequenceString, true,
false,
On 2016/09/15 11:19:02, nisse-webrtc wrote:
> And similarly for sequences, const std::vector, and in this case const
> std::vector<const std::string>.

Dito.

[hbos, 2016-09-15 12:20:05]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-09-15 12:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2340303002/#ps20001 (title:
"Fixed error")

[commit-bot: I haz the power, 2016-09-15 12:20:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-09-15 12:21:02]

The CQ bit was unchecked by hbos@webrtc.org

[hbos, 2016-09-15 12:22:35]

Aborted landing, will have to wait for
https://codereview.chromium.org/2340603004/ to land or else I will break
chromium.

[hbos, 2016-09-15 12:56:26]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-09-15 12:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-09-15 13:39:26]

The CQ bit was unchecked by hbos@webrtc.org

[hbos, 2016-09-15 13:40:21]

As always, an android bot is timing out. Landing with NOTRY since git cl land
doesn't work for me.

[hbos, 2016-09-15 13:40:50]

Description was changed from

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
==========

to

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True
==========

[hbos, 2016-09-15 13:41:07]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-09-15 13:41:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-15 13:52:48]

Description was changed from

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True
==========

to

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-15 13:52:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 13:52:56]

Description was changed from

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True
==========

to

==========
Removed the const char* (StaticString) type from RTCStatsMember.

std::string is all we need. const char* is an annoying special case
because they can't be compared with ==. Having two different string
types was a premature optimization.

BUG=chromium:627816
NOTRY=True

Committed: https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
Cr-Commit-Position: refs/heads/master@{#14235}
==========

[commit-bot: I haz the power, 2016-09-15 13:52:57]

Patchset 2 (id:??) landed as
https://crrev.com/8faf9e047ee80b45d1a28d6c038cbd6e222f23cd
Cr-Commit-Position: refs/heads/master@{#14235}